Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add or modify interfaces of from_euler functions to support quantities #776

Open
vhirtham opened this issue Jun 22, 2022 · 1 comment
Open
Labels
refactor transformations everything related to the LCS / CSM units unit handling and pint

Comments

@vhirtham
Copy link
Collaborator

While refactoring the LCS tutorial I used the from_euler functions a lot. They currently require something like this:

WelDXClass.from_euler(sequence="x", angles=[1], degrees=False)

The combined parameters angles and degrees are basically just information that can be expressed by a quantity.
I think we should modify the interface to support pint.Quantity to be consistent with the rest of the code base and we can write something like this instead:

WelDXClass.from_euler(sequence="x", angles="1rad")
@vhirtham vhirtham added transformations everything related to the LCS / CSM units unit handling and pint refactor labels Jun 22, 2022
@CagtayFabry
Copy link
Member

We could implement this using WXRotation (which we should do anyway instead of scipy) in .from_euler since WXRotation can already handle quantities as inputs by always converting to quantities like we do in the other classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor transformations everything related to the LCS / CSM units unit handling and pint
Projects
None yet
Development

No branches or pull requests

2 participants