Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downgrading precision on fill_Point #106

Open
vfonov opened this issue Mar 13, 2019 · 1 comment
Open

downgrading precision on fill_Point #106

vfonov opened this issue Mar 13, 2019 · 1 comment

Comments

@vfonov
Copy link
Member

vfonov commented Mar 13, 2019 •
edited

https://github.com/BIC-MNI/libminc/blob/develop/volume_io/Include/volume_io/geom_structs.h#L69

Accoriding to Claude Lepage, this macro is used in many places with double precision data , but it explicitly converts values to float , causing loss of precision.
@gdevenyi
Copy link
Contributor

Dumbest solution, convert to double:
https://github.com/BIC-MNI/libminc/blob/develop/volume_io/Include/volume_io/geom_structs.h#L51

If VIO_Point_coord_type is being used consistently, it should upgrade everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vfonov @gdevenyi