Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Split the IConstructorResolver interface #144

Open
Barsonax opened this issue Apr 2, 2020 · 0 comments
Open

Split the IConstructorResolver interface #144

Barsonax opened this issue Apr 2, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Barsonax
Copy link
Owner

Barsonax commented Apr 2, 2020

Is your feature request related to a problem? Please describe.
Currently both static and dynamic constructor selection is done with this interface. This makes the interface less clean than it could be and leads to some implementations sometimes only throwing a notimplemented exception because its not used.

Describe the solution you'd like
Split the interface in a dynamic and a static constructor selector interface. Also while changing this code try to reduce duplicate code for both clarity and performance. For instance constructor candidates are searched for twice then using the dynamic constructor selector currently. A option/result like type encapsulating the result of the static constructor selection could solve this.

@Barsonax Barsonax added the enhancement New feature or request label Apr 2, 2020
@Barsonax Barsonax self-assigned this Apr 2, 2020
@Barsonax Barsonax changed the title Split IConstructorResolver Split theIConstructorResolver interface Apr 2, 2020
@Barsonax Barsonax changed the title Split theIConstructorResolver interface Split the IConstructorResolver interface Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant