Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost PDF filenames (multiple share) #585

Open
Deleplace opened this issue Mar 17, 2024 · 6 comments
Open

Lost PDF filenames (multiple share) #585

Deleplace opened this issue Mar 17, 2024 · 6 comments
Labels

Comments

@Deleplace
Copy link
Collaborator

From @MaBeuLux88 in #284 :

[Lost filenames] while uploading 2 PDF files from an Android (One Plus 9 Pro) selected in the "Files" app and sharing them to CoolMaze on my Ubuntu with Google Chrome

@Deleplace
Copy link
Collaborator Author

Today I tried sharing 2 PDF from the Files app on a Samsung Galaxy S22. The filenames were properly transmitted, in the target web UI and in the resulting ZIP as well.

@Deleplace
Copy link
Collaborator Author

For debugging this issue: note that the backend only sees an opaque encrypted value for the filenames. It cannot see the clear text filenames.

@Deleplace
Copy link
Collaborator Author

Today I tried sharing 2 PDF from the Files app on a Google Pixel 7. The filenames were lost! The contents listed in the ZIP showed up as:

  • undefined
  • 1_undefined

@Deleplace
Copy link
Collaborator Author

When sharing these files individually, from the same Pixel 7, the filenames are properly preserved. They were lost only when shared together in a single action.

@MaBeuLux88
Copy link

This sounds very similar to my bug. I got the same filenames. No file corruption though. Just file name alterations.

@Deleplace
Copy link
Collaborator Author

While I don't have access to the filenames, I can still extract stats about shares that don't seem to be providing a proper filename.

Results:

  • iOS app mostly unaffected
  • Android app affected: ~7% of files transmitted end up without a proper filename
    • it is possible that some source apps don't provide a filename when sharing a resource
    • but more probably, the Cool Maze Android app failed to properly extract the filename from the Intent
  • no obvious correlation with the OS version (Android 6, 7, 8, 9, 10, 11, 12, 13, 14)
  • no obvious correlation with the smartphone device model
  • no obvious correlation with the mime type of the file
  • no obvious correlation with the number of resources shared in one action. Filenames can be lost either in a single share action, or in a multiple share action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants