Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart FN Lock tends to fail to register Alt key release event, when toggling HDR on/off quickly using Win+Alt+B shortcut, if LLT Dashboard page is being displayed. #1254

Open
3 tasks done
ZZZXXX0110 opened this issue Apr 16, 2024 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ZZZXXX0110
Copy link

ZZZXXX0110 commented Apr 16, 2024

Rules

  • I made myself familiar with the README.
  • I checked closed issues for similar ones and did not find a similar problem mentioned before.
  • I understand that, if insufficient information was provided, my issue will be closed without an answer.

Version

2.21.1

OS

Windows 23H2 build 22631.3447

Device

Legion 7i 16IAX7 (7th gen)

BIOS version

BIOS Version/Date LENOVO K1CN44WW, 8/17/2023

What's wrong?

When using the Windows's built-in keyboard shortcut for toggling HDR on and off, Win+Alt+B, and when doing so very quickly (for example, releasing Win, Alt, and B keys faster than the screen blackout that's part of the HDR toggling process), the Smart FN Lock feature would fail to register the Alt key release event, and FN lock would remain disabled despite Alt key having already become released.

Tapping Alt key again normally after toggling HDR allows Alt key release event to properly register, and Smart FN Lock functions correctly once again.

Note that this only happens, if the Dashboard page of LLT is the current selected page in LLT, regardless of whether LLT window is actually being displayed (including if LLT window is closed). Having or not having the HDR toggle button enabled in LLT Dashboard page also has no effect on the occurrence of this bug. Whether Smart FN Lock is configured to only respond to Alt key, or is configured to respond to all of Shift, Ctrl and Alt key, also has no effect on the occurrence of this bug.

For example, if I select the Dashboard page in LLT, then change focus to another window, or close LLT by clicking on the "X" on LLT window's title bar, this bug would still occur. However, if I instead select any page other than Dashboard (Battery, Keyboard, Settings, Donate page, etc.) in LLT, then this bug would not happen.

If the conditions are met and LLT's Dashboard is the current page in LLT, the only way to avoid this bug is to keep Alt key held down considerably longer than the duration of HDR toggling, like 2 seconds for example, instead of simply tapping the keyboard shortcut.

How to reproduce the bug?

  1. Go to LLT main window, select Dashboard page in LLT.
  2. Engage FN Lock.
  3. Quickly tapping the Win+Alt+B shortcut. As in, release the keys immediately after they are pressed. Verify that screen goes black and back on, as one would expect when toggling HDR on or off.
  4. Notice how FN Lock remains disengage, despite of Alt key being already released.

What is the behavior that you expected?

Smart FN Lock functions as expected, with FN Lock disengaging when the selected modifier key is held down, and re-engage when the modifier key is released.

Logs

log_2024_04_16_11_32_11.txt

Additional information

No response

@ZZZXXX0110 ZZZXXX0110 added the bug Something isn't working label Apr 16, 2024
@BartoszCichecki
Copy link
Owner

I couldn't make it happen on my laptop, so I will mark it as "help wanted".

@BartoszCichecki BartoszCichecki added the help wanted Extra attention is needed label Apr 23, 2024
@ZZZXXX0110
Copy link
Author

I couldn't make it happen on my laptop, so I will mark it as "help wanted".

Oooo would it help to make a video recording of what I do on the keyboard when I replicate this bug?

@Weresk

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants