Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply pagination macro to all requests #59

Closed
kevin-pease opened this issue May 1, 2024 · 0 comments · Fixed by #78
Closed

Apply pagination macro to all requests #59

kevin-pease opened this issue May 1, 2024 · 0 comments · Fixed by #78
Assignees
@kevin-pease
Labels
enhancement New feature or request

Comments

@kevin-pease
Copy link
Contributor

The recently introduced pagination macro is currently only used in a few endpoints; we need to apply it where applicable. This will increase uniformity, and will remove duplicate code.

See operations_for_liquidity_pool_request.rs and all_offers_request.rs for examples.
@kevin-pease kevin-pease added the enhancement New feature or request label May 1, 2024
@kevin-pease kevin-pease changed the title Apply pagination macro in all requests Apply pagination macro in to requests May 1, 2024
@kevin-pease kevin-pease changed the title Apply pagination macro in to requests Apply pagination macro to all requests May 1, 2024
@kevin-pease kevin-pease self-assigned this May 24, 2024
@kevin-pease kevin-pease mentioned this issue May 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin-pease kevin-pease

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply pagination macro to all requests Baseflow/stellar-rust-sdk
1 participant
@kevin-pease