Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with Symfony 4 #98

Open
junowilderness opened this issue Nov 17, 2017 · 13 comments
Open

Make compatible with Symfony 4 #98

junowilderness opened this issue Nov 17, 2017 · 13 comments

Comments

@junowilderness
Copy link

See http://symfony.com/blog/helping-prepare-for-symfony-4-bundle-support

@acidjames
Copy link
Collaborator

Hi @cilefen i've updated the googledocs, i'm going to work on it this week

i'll keep you posted :)

@junowilderness
Copy link
Author

@acidjames I am available to help test against SF4 when ready.

@acidjames
Copy link
Collaborator

@cilefen thanks, let's try both then, better be more than alone !

I'll try to update about my tests this coming week

see you, and have fun !

@acidjames
Copy link
Collaborator

acidjames commented Nov 18, 2017

Progress can be seen here : https://github.com/acidjames/BeSimpleSsoAuthBundle

https://travis-ci.org/acidjames/BeSimpleSsoAuthBundle

Tests are running but failing ATM, you can use my .travis.yml, Makefile

You also need to reformat Resources/config .yml files if you want tests to run

@acidjames
Copy link
Collaborator

acidjames commented Nov 29, 2017

@cilefen Hi, any advances ?

Seems like this project needs a lot of rework to make tests successful in Travis, what do you think ?

(dependencies not met)

@junowilderness
Copy link
Author

@acidjames Sorry, I've nothing to add right now. Indeed this is true. Actually, this needs work in order to pass tests at all, as I couldn't get phpunit to pass locally.

@junowilderness
Copy link
Author

junowilderness commented Nov 29, 2017

@acidjames There is a tracking sheet: https://docs.google.com/spreadsheets/d/1mFHQPp

@junowilderness
Copy link
Author

@acidjames Oh some of this is my ignorance of bundle testing.

@acidjames
Copy link
Collaborator

@cilefen me too ... don't worry

@junowilderness
Copy link
Author

@acidjames See also PRayno/CasAuthBundle#11

@acidjames
Copy link
Collaborator

@cilefen this is another bundle right ? For users looking for an alternative ?

@junowilderness
Copy link
Author

@acidjames Yes. It uses Symfony Guard and is simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants