Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phar is broken for the 3.14.0 release #1456

Open
jakzal opened this issue Jan 12, 2024 · 4 comments
Open

phar is broken for the 3.14.0 release #1456

jakzal opened this issue Jan 12, 2024 · 4 comments

Comments

@jakzal
Copy link
Contributor

jakzal commented Jan 12, 2024

Steps to reproduce

wget https://github.com/Behat/Behat/releases/download/v3.14.0/behat.phar
php behat.phar --version

Expected result

Outputs the version

behat 3.14.0

Actual result

Fatal error:

Fatal error: Uncaught PharException: manifest cannot be larger than 100 MB in phar "/project/behat.phar" in /project/behat.phar:9
Stack trace:
#0 /project/behat.phar(9): Phar::mapPhar('default.phar')
#1 {main}
  thrown in /project/behat.phar on line 9

Reproduction steps

Environment

PHP 8.3 from the official Docker image.

@jakzal
Copy link
Contributor Author

jakzal commented Jan 16, 2024

Looking at the recent changes, the only relevant change that could break the phar during the upload is #1430.

@stof
Copy link
Member

stof commented Jan 16, 2024

looking at this, it does not look like an issue with the upload to the github release but with the generated phar itself.

So I'd rather suspect a change done in Box (the release workflow uses the latest version of Box AFAICT, so it also changes between releases)

@theofidry
Copy link

theofidry commented Jan 22, 2024

I'll check this ASAP, but I would highly recommend Behat to do a smoke test of the PHAR at least, e.g. calling behat.phar --version, as part of the CI

@theofidry
Copy link

Looking at this it's not really worth for me to try to investigate this any further.

I'm happy to help if there is issues with upgrading, but I'm not willing to support a version I had no hands in and that is 7 years old.

jakzal added a commit to jakzal/toolbox that referenced this issue Feb 11, 2024
The phar remains broken and is not currently tested.

See Behat/Behat#1456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants