Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link text styling #48

Open
connectdotz opened this issue Jun 25, 2020 · 0 comments
Open

link text styling #48

connectdotz opened this issue Jun 25, 2020 · 0 comments

Comments

@connectdotz
Copy link

hi, I was able to use the styles={{text: {color:xxx}} to change all text colors, which is very cool, however there is a problem for link, the color of link got override by the text styles above. Looking at the code textContentRenderer, it seems that you did try to provide some override with the "styleName2", however for link, a nested renderer, it renders the actual link text with the default textContentRenderer and thus lost the link's style...

To make a long story short, I see couple of issues here and wanted to check with you before submitting PR to address them:

  1. the "text" style should be added to styles.js so people know they can use it to pass text style.
  2. allow nested renderers such as the link to pass its style info to the child renderer (maybe through state?). So the link renderer can set styleName2='link', or something like that, in the state, and the text renderer can then use it to provider correct override

is this something you will consider accepting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant