Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: BenoitZugmeyer/eslint-plugin-html
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.0.6
Choose a base ref
...
head repository: BenoitZugmeyer/eslint-plugin-html
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.0.0
Choose a head ref
  • 9 commits
  • 10 files changed
  • 1 contributor

Commits on Sep 22, 2018

  1. Copy the full SHA
    e758302 View commit details
  2. Copy the full SHA
    880226e View commit details
  3. Copy the full SHA
    111bd85 View commit details

Commits on Nov 11, 2018

  1. Copy the full SHA
    8706cb1 View commit details
  2. chore: drop support of Node.js 4 from travis

    The plugin tests were executed in Node.js 4, but ESLint 5 does not support
    Node.js 4 anymore, so tests are failing.  Follow the ESLint release and
    drop support from Node.js 4 too.
    BenoitZugmeyer committed Nov 11, 2018
    Copy the full SHA
    d4c44ec View commit details
  3. code cleanup

    BenoitZugmeyer committed Nov 11, 2018
    Copy the full SHA
    84df755 View commit details
  4. improv: drop support for Vue files

    Breaking change.  `eslint-plugin-html` should not be used to lint vue
    files, since the vue puglin is far superior for this usage.
    
    Fixes #103
    BenoitZugmeyer committed Nov 11, 2018
    Copy the full SHA
    8f4bee9 View commit details
  5. Copy the full SHA
    8ab313b View commit details
  6. 5.0.0

    BenoitZugmeyer committed Nov 11, 2018
    Copy the full SHA
    7038332 View commit details
Showing with 4,171 additions and 1,912 deletions.
  1. +31 −0 .github/ISSUE_TEMPLATE/bug-report.md
  2. +23 −0 .github/ISSUE_TEMPLATE/feature_request.md
  3. +2 −2 .travis.yml
  4. +6 −0 CHANGELOG.md
  5. +4 −4 README.md
  6. +3,975 −1,773 npm-shrinkwrap.json
  7. +6 −6 package.json
  8. +1 −0 src/extract.js
  9. +121 −124 src/index.js
  10. +2 −3 src/settings.js
31 changes: 31 additions & 0 deletions .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
---
name: Bug report
about: Report a bug or a misbehaviour

---

## Description

<!--
Describe the issue precisely: what are you trying to do? what's the expected result?
-->

## Setup configuration

* ESLint version:
* eslint-plugin-html version:
* NodeJS version:
* Operating System name and version:
* ESLint configuration (.eslintrc):

<!--
If run from an editor plugin:
-->
* Editor name and version:
* Plugin name and version:

## Aditional context

<!--
If you can provide a lock file (package-lock.json, yarn.lock...) or a link to a repository or gist, that would help.
-->
23 changes: 23 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
name: Feature request
about: Suggest an idea for this project

---

## Description

<!--
A clear and concise description of what the problem is, and what you want to happen. Ex. I'm always frustrated when [...]
-->

## Alternatives

<!--
A clear and concise description of any alternative solutions or features you've considered.
-->

## Additional context

<!--
Add any other context or screenshots about the feature request here.
-->
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
language: node_js
node_js:
- 4
- 6
- 8
- 10
script:
- if node --version | grep -q v8; then npm run lint; fi
- if node --version | grep -q v10; then npm run lint; fi
- npm install eslint@4.7 && npm test
- if ! node --version | grep -q v4; then npm install eslint@latest && npm test; fi
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
2018-11-11 v5
* **Breaking: drop support of Node.js 4**
* **Breaking: don't lint .vue files by default**
* Update dependencies

2018-09-22 v4.0.6
* Ignore script tags with a `src` attribute #102
* More detailed error reporting

2018-06-20 v4.0.5
* Fix typo regression from v4.0.4
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -113,8 +113,8 @@ Settings
### `html/html-extensions`

By default, this plugin will only consider files ending with those extensions as HTML: `.erb`,
`.handlebars`, `.hbs`, `.htm`, `.html`, `.mustache`, `.nunjucks`, `.php`, `.tag`, `.twig`, `.vue`,
`.we`. You can set your own list of HTML extensions by using this setting. Example:
`.handlebars`, `.hbs`, `.htm`, `.html`, `.mustache`, `.nunjucks`, `.php`, `.tag`, `.twig`, `.we`.
You can set your own list of HTML extensions by using this setting. Example:

```javascript
{
@@ -221,5 +221,5 @@ console.log(mydata);

Initially, [`eslint-plugin-vue`](https://github.com/vuejs/eslint-plugin-vue) was using
`eslint-plugin-html` to lint code inside script tags. Since v3, `eslint-plugin-vue` is using its
own parser, so it is *incompatible* with `eslint-plugin-html`. You should remove
`eslint-plugin-html` from your dependencies if you still have this.
own parser, so it is *incompatible* with `eslint-plugin-html`. You should use `eslint-plugin-vue`
exclusively and remove `eslint-plugin-html` from your dependencies if you still have it.
Loading