Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: remote.dialog.showMessageBox(...).then is not a function #132

Open
mellester opened this issue Oct 31, 2020 · 1 comment

Comments

@mellester
Copy link

[Enter steps to reproduce:]

  1. Updated to latest package
  2. Pressed Get -sripts

Atom: 1.40.0 x64
Electron: 3.1.10
OS: Microsoft Windows 10 Pro
Thrown From: tabletopsimulator-lua package 12.4.3

Stack Trace

Uncaught TypeError: remote.dialog.showMessageBox(...).then is not a function

At C:\Users\Melle\.atom\packages\tabletopsimulator-lua\lib\tabletopsimulator-lua.coffee:1223

TypeError: remote.dialog.showMessageBox(...).then is not a function
    at Object.getObjects (/packages/tabletopsimulator-lua/lib/tabletopsimulator-lua.coffee:1223:8)
    at /packages/tabletopsimulator-lua/lib/tabletopsimulator-lua.coffee:901:100)
    at CommandRegistry.handleCommandEvent (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:349123)
    at CommandRegistry.dispatch (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:347598)
    at AtomEnvironment.dispatchApplicationMenuCommand (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:1:757879)
    at EventEmitter.t (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:1:765802)
    at EventEmitter.emit (events.js:182:13)

Commands

     -0:43.4.0 tabletopsimulator-lua:getObjects (div.tool-panel.tree-view)
     -0:20.7.0 tree-view:remove-project-folder (span.name.icon.icon-file-directory)
     -0:18.5.0 tabletopsimulator-lua:getObjects (div.tool-panel.tree-view)

Non-Core Packages

compare-files 0.8.1 
tabletopsimulator-lua 12.4.3 

Not sure why but showMessageBox() apparently did not return a promise object. I Downgraded my version so I would not get this error anymore

@Benjamin-Dobell
Copy link
Member

Benjamin-Dobell commented Oct 31, 2020

Yeah, this is super annoying. Electron broke backward compatibility and Atom bumped its version. Rather than downgrading this plugin, you should instead upgrade Atom to the latest release 1.52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants