Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D View - Object Header - Modifier Sub-menu cleanup #4254

Open
Draise14 opened this issue May 15, 2024 · 1 comment
Open

3D View - Object Header - Modifier Sub-menu cleanup #4254

Draise14 opened this issue May 15, 2024 · 1 comment
Labels
0 - task A normal development task

Comments

@Draise14
Copy link
Collaborator

Draise14 commented May 15, 2024

bforartists_JCiDgXXEwo
For some... reason.. consistency maybe?
They have added modifiers to the 3D View...

Reasons this is not a good idea

  1. Redundant bloat, where you manage modifiers from the Properties editor, so I'd expect to add from there only. Why from viewport?
  2. Modifiers don't use targets like constraints, so the consistency is inconsistent.

Tasks

  • Remove icons from the sub-menu folders
  • Add icons to the copy to selected operator (has a duplicate now.. another task)
  • Add icon to clear modifiers operator (3D View exclusive)
Details

SHA-1: e63c8bb

  • UI: Add Modifiers submenu to 3D view header

Add a menu similar to the "Object > Constraints" menu that allows adding,
copying, and clearing modifiers. The "copy all modifiers to selected" and
"clear modifiers" operators are new, to mirror the functionality we already
have for constraints.

The "Add" menu is the same that's used in the property editor. In the 3D
view, modifiers are always added to all selected objects.

Part of #120230

Pull Request: https://projects.blender.org/blender/blender/pulls/121286

More Details

SHA-1: a3627fe

  • UI: Tweaks to Object > Modifier menu
  • Moved Modifier menu above Constraints, so that order matches Properties panel
  • Added icons for Modifier and Constraints menu (same ones as Properties)
  • Renamed "Add" to "Add Modifier", so that it's easier to search for it with F3
  • Renamed "Copy Modifiers" operator to match similar operator in constraints menu
  • "Add Modifier" operator now doesn't appear if active object type doesn't support
    modifiers. I completely removed it because otherwise it was showing menu with
    empty items even on greyed out

Lastly, I added check for legacy GPENCIL object type, because it doesn't support
new modifier menus, and instead when active object is grease pencil instead of
menu it shows old Add Modifier operator, same one that is in properties panel.

After legacy grease pencil is removed that check won't be necessary anymore and
can be removed, but for now it's needed, otherwise it shows empty menu for grease pencil.

Pull Request: https://projects.blender.org/blender/blender/pulls/121344

@Draise14 Draise14 added the 0 - task A normal development task label May 15, 2024
@Draise14
Copy link
Collaborator Author

If we do keep the Add Modifier, then in that case it should be the floating menu for consistency (like the property shelf) and these could be also added to the Utility Shelf

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - task A normal development task
Projects
None yet
Development

No branches or pull requests

1 participant