Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Shelf - Armature Pose Asset - Context Menu has missing icons #4260

Closed
Draise14 opened this issue May 15, 2024 · 7 comments
Closed

Asset Shelf - Armature Pose Asset - Context Menu has missing icons #4260

Draise14 opened this issue May 15, 2024 · 7 comments
Assignees
Labels
0 - task A normal development task 1- Fixed This task is fulfilled

Comments

@Draise14
Copy link
Collaborator

Current

image

File Browser

image

Right now there are two entries without icons, but the icons exist.

Potential Details?

SHA-1: 7982192

  • Asset Shelf: Add optional operator to activate assets

The operator stored when registering the asset shelf will be called
with properties that reference the asset (a weak reference, split into
three properties already used in other asset-related operators). The
operator is called whenever a grid view item is activated, and is
meant to do things like import and activate a brush asset.

Previously Reviewed: https://projects.blender.org/blender/blender/pulls/117861

Pull Request: https://projects.blender.org/blender/blender/pulls/121402

@Draise14 Draise14 added the 0 - task A normal development task label May 15, 2024
@ReinerBforartists ReinerBforartists self-assigned this May 20, 2024
@ReinerBforartists
Copy link
Contributor

This menu comes from an addon.

Tough one. We had decided not to maintain addons. But this seems to be core functionality.

While searching for this i stumbled across that we have the pose library addon in both , the addons folder, and the addons_core folder. I guess one is redundant?

@ReinerBforartists
Copy link
Contributor

Making a task ...

double

@ReinerBforartists
Copy link
Contributor

Related: Double addon set pose library #4292

The related issue should be fixed first ...

@ReinerBforartists ReinerBforartists removed their assignment May 20, 2024
@Draise14 Draise14 self-assigned this May 23, 2024
@Draise14
Copy link
Collaborator Author

Hmm... I will try migrate the legacy addons to extensions with our changes and see if I can get them to "ship" as a user default.

@Draise14
Copy link
Collaborator Author

Migrated, now can be fixed. This is now a core addon.

@Draise14 Draise14 removed their assignment May 28, 2024
@Draise14 Draise14 self-assigned this Jun 4, 2024
@Draise14
Copy link
Collaborator Author

Draise14 commented Jun 4, 2024

Checking if it needs documentation

@Draise14
Copy link
Collaborator Author

Draise14 commented Jun 4, 2024

Default addon, so documented it a bit better.

@Draise14 Draise14 closed this as completed Jun 4, 2024
@Draise14 Draise14 added the 1- Fixed This task is fulfilled label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - task A normal development task 1- Fixed This task is fulfilled
Projects
None yet
Development

No branches or pull requests

2 participants