Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compositor - Sidebar - Options - Float checkboxes left (and remove legacy features from documentation) #4263

Closed
Draise14 opened this issue May 15, 2024 · 1 comment
Assignees
Labels
0 - task A normal development task

Comments

@Draise14
Copy link
Collaborator

Draise14 commented May 15, 2024

image

This panel is making moves to the GPU compositor, now moved out of experimental in next merge. But with that things got mc-gucky and needs a bit of love. Documentation also needs to be stripped back down.

Details

SHA-1: 6db8091

  • Compositor: Remove Two Pass option

There are few issues with the logic and implementation of this option:

  • While the first pass is faster in the terms of a wall-clock time, it
    is often not giving usable results to artists, as the final look of
    the result is so much different from what it is expected to be.

  • It is not supported by the GPU compositor.

  • It is based on some static rules based on the node type, rather than
    on the apparent computational complexity.

The performance settings are planned to be moved to the RenderData, and
it is unideal to carry on such limited functionality to more places. There
are better approaches to quickly provide approximated results, which we can
look into later.

Pull Request: https://projects.blender.org/blender/blender/pulls/121558

Details

SHA-1: 9532ea3

  • Compositor: Remove Render/Edit Quality setting

The setting was only affecting some of the blur operations, which
does not typically results in a measurable performance boost in real
compositor setups.

For the simplicity of settings on user level remove setting which
potentially makes compositor output worse, without much benefit.

There are better ways to gain performance, like compositing on a
lower resolution, exposing "preview" as an input to the node tree
(similar to the geometry nodes) etc.

Pull Request: https://projects.blender.org/blender/blender/pulls/121576

Details

SHA-1: 149e547

  • Compositor: Remove quality setting from DNA and UI

It was meant to be included into the previous commit in the area,
but was forgotten due to some technicalities.

Also remove the DisplaceSimpleOperation, which is now not used.

Pull Request: https://projects.blender.org/blender/blender/pulls/121580

Details

SHA-1: 7b4232e

  • Compositor: Move Execution Mode and Precision from bNodeTree to Scene

This allows to expose these settings in the Performance panel in the
render buttons. Also moves compositor-specific options away from the
generic node tree structure.

For the backwards-compatibility the options are still present in the
DNA for the bNodeTree. This is to minimize the impact on the Studio
which has used the GPU compositor for a while now. They can be
removed in a future release.

There is no functional changes expected.

Pull Request: https://projects.blender.org/blender/blender/pulls/121583

@Draise14 Draise14 added the 0 - task A normal development task label May 15, 2024
@Draise14 Draise14 self-assigned this Jun 5, 2024
@Draise14
Copy link
Collaborator Author

Draise14 commented Jun 5, 2024

Documenting.

Image

Draise14 added a commit that referenced this issue Jun 5, 2024
Draise14 added a commit to Bforartists/Manual that referenced this issue Jun 5, 2024
@Draise14 Draise14 closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - task A normal development task
Projects
None yet
Development

No branches or pull requests

1 participant