About Current Pull Requests

[hasanmanzak]

As of now (14.05.2021 23:25 UTC) there are 8 open pull requests:

• Allow filtering and sorting for nested objects based on attributes #65
• Let you choose the Culture used for TypeConversion in the processor #79
• Set SieveProcessor _options as a protected Property - see Issue 108 #109
• #111: pass filter values as parameters #112
• #80 added support for escaping pipe control characters #113
• stop excluding null values when filtering using notEqual #114
• Nested objects by attribute #117 &
• Fix merge conflicts for: Let you choose the Culture used for TypeConversion in the processor #79 #125

@ITDancer13, @a-patel and I are writing back to the authors to resolve the current conflicts. Some PRs are very old, some are very new but the problem remains: there are conflicts and we are expecting people to fix them.

I say lets checkout the PRs ourselves and resolve the conflicts, if any, and merge the fixes/changes and close those long waited issues.. That way we can start a clean page and say, do an enforcement about contribution like "write the unit tests about the fix/feature you are contributing", or close the PR if builds are failing or something or some other thing I couldn't thought about.

Any thoughts?

[ITDancer13]

Another great idea :-)
#113 is ready to be merged

[hasanmanzak]

Merged

[hasanmanzak]

Closed #65. It was superseeded by #117
Closed #79. It was superseeded by #125

[hasanmanzak]

#109 is closed but merged the functionality with #134

[ITDancer13]

I'll take #112 now. Resolve the conflicts and check the result.