Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace trimmed for ISieveCustomFilterMethods #120

Open
lukaepti opened this issue Mar 1, 2021 · 2 comments
Open

Whitespace trimmed for ISieveCustomFilterMethods #120

lukaepti opened this issue Mar 1, 2021 · 2 comments

Comments

@lukaepti
Copy link

lukaepti commented Mar 1, 2021

Problem:
Custom filter methods get called with values trimmed of spaces and tabs on either side

Expectation:
The original value passed in, with white space characters intact

@lukaepti lukaepti changed the title Spaces trimmed before calling ISieveCustomFilterMethods Whitespace trimmed for ISieveCustomFilterMethods Mar 1, 2021
@hasanmanzak
Copy link
Collaborator

I think a search pattern structure could be implemented to achieve something like google does: " text the text ". Or treat this as a bug and change the code and break existing consumers.

Either way, the questions are the same:

Does the risk of a braking change outways the benefit of the default trimming?
Does the open possibilities to an encapsulator structure outway the benefit of the simple value approach?

@codequality44
Copy link

I see this issue is closed, but I still see this behaviour.

Is there are solution to this currently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants