Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by some special characters doesn't work #91

Open
maryuraeva opened this issue Jul 9, 2020 · 0 comments · May be fixed by #175
Open

Filter by some special characters doesn't work #91

maryuraeva opened this issue Jul 9, 2020 · 0 comments · May be fixed by #175

Comments

@maryuraeva
Copy link

maryuraeva commented Jul 9, 2020

Filters don't work when searched value contains:

  1. {some_text}<
  2. {some_text}>
  3. {some_text},{some_text}
  4. {some_text}|
  5. {some_text}.
  6. <>
  7. ,
  8. =
  9. and in other cases with special characters

In some case it throws error "The binary operator GreaterThan/Less than is not defined" or "{some_text} not found" and in other cases just returns all data.

I investigate this and found out that the issue with <>= characters is in regexp for filterSplits here:
https://github.com/Biarity/Sieve/blob/master/Sieve/Models/FilterTerm.cs#L36
Special characters considered as Operators in this case.

Also, issue with comma is in regexp for filters:
https://github.com/Biarity/Sieve/blob/master/Sieve/Models/SieveModel.cs#L35

These fixes require a lot of improvements in the library logic, and it will be great if you add support for special characters.

Thanks in advance!

@ArnoutBorn ArnoutBorn linked a pull request Jun 3, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant