Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apps/whale-api): attempting to write test for whale.api.wallet.test.ts #1941

Closed
wants to merge 1 commit into from
Closed

feat(apps/whale-api): attempting to write test for whale.api.wallet.test.ts #1941

wants to merge 1 commit into from

Conversation

DieHard073055
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #1819

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Dec 20, 2022

Code Climate has analyzed commit a295911 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Dec 20, 2022

✅ Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit a295911
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/63a13108792d2f000874bb23
😎 Deploy Preview https://deploy-preview-1941--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Dec 20, 2022 •
edited

Codecov Report

Base: 87.31% // Head: 92.30% // Increases project coverage by +4.98% 🎉

Coverage data is based on head (a295911) compared to base (811b258).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1941      +/-   ##
==========================================
+ Coverage   87.31%   92.30%   +4.98%     
==========================================
  Files         358      361       +3     
  Lines       10526    10588      +62     
  Branches     1340     1355      +15     
==========================================
+ Hits         9191     9773     +582     
+ Misses       1259      783     -476     
+ Partials       76       32      -44
Impacted Files Coverage Δ
packages/ocean-api-client/src/ApiResponse.ts 6.25% <0.00%> (-93.75%) ⬇️
...playground-api/src/controllers/WalletController.ts 26.19% <0.00%> (-73.81%) ⬇️
...es/ocean-api-client/src/errors/TimeoutException.ts 33.33% <0.00%> (-66.67%) ⬇️
packages/playground-api-client/src/apis/Wallet.ts 16.66% <0.00%> (-66.67%) ⬇️
packages/whale-api-client/src/whale.rpc.client.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/jellyfish-wallet-mnemonic/src/mnemonic.ts 63.63% <0.00%> (-36.37%) ⬇️
...sh-transaction-builder/src/txn/txn_builder_utxo.ts 65.00% <0.00%> (-35.00%) ⬇️
...ish-transaction-builder/src/txn/txn_builder_dex.ts 71.42% <0.00%> (-28.58%) ⬇️
...transaction-builder/src/txn/txn_builder_account.ts 67.56% <0.00%> (-27.03%) ⬇️
...nsaction-builder/src/txn/txn_builder_masternode.ts 80.00% <0.00%> (-20.00%) ⬇️
... and 100 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Docker build preview for jellyfish/apps is ready!

Built with commit b1ed282

  • ghcr.io/jellyfishsdk/legacy-api:pr-1941
  • ghcr.io/jellyfishsdk/ocean-api:pr-1941
  • ghcr.io/jellyfishsdk/playground-api:pr-1941
  • ghcr.io/jellyfishsdk/status-api:pr-1941
  • ghcr.io/jellyfishsdk/whale-api:pr-1941

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:b1ed282ac15f3d8fd3427cbf664874bc16995d6d
  • ghcr.io/jellyfishsdk/ocean-api:b1ed282ac15f3d8fd3427cbf664874bc16995d6d
  • ghcr.io/jellyfishsdk/playground-api:b1ed282ac15f3d8fd3427cbf664874bc16995d6d
  • ghcr.io/jellyfishsdk/status-api:b1ed282ac15f3d8fd3427cbf664874bc16995d6d
  • ghcr.io/jellyfishsdk/whale-api:b1ed282ac15f3d8fd3427cbf664874bc16995d6d

@fuxingloh fuxingloh marked this pull request as draft December 22, 2022 09:39
@fuxingloh fuxingloh changed the title (WIP): attempting to write test for whale.api.wallet.test.ts feat(apps/whale-api): attempting to write test for whale.api.wallet.test.ts Jan 19, 2023
@github-actions github-actions bot added the kind/feature New feature request label Jan 19, 2023
@fuxingloh fuxingloh closed this Jan 31, 2023
@fuxingloh fuxingloh deleted the diehard073055/whaleprevoutprovider branch January 31, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuxingloh fuxingloh Awaiting requested review from fuxingloh fuxingloh is a code owner

@canonbrother canonbrother Awaiting requested review from canonbrother canonbrother is a code owner

@ivan-zynesis ivan-zynesis Awaiting requested review from ivan-zynesis ivan-zynesis is a code owner

@kodemon kodemon Awaiting requested review from kodemon

@eli-lim eli-lim Awaiting requested review from eli-lim eli-lim is a code owner

@thedoublejay thedoublejay Awaiting requested review from thedoublejay thedoublejay will be requested when the pull request is marked ready for review thedoublejay is a code owner

@pierregee pierregee Awaiting requested review from pierregee pierregee will be requested when the pull request is marked ready for review pierregee is a code owner

Assignees
No one assigned
Labels
area/packages kind/feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WhalePrevoutProvider should ignore UTXO that are Immature (<100 confirmations)
2 participants
@DieHard073055 @fuxingloh