Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sufficient tests for NativeChainContainer.setDefiConf #1940

Open
infinia-yzl opened this issue Dec 19, 2022 · 3 comments
Open

Add sufficient tests for NativeChainContainer.setDefiConf #1940

infinia-yzl opened this issue Dec 19, 2022 · 3 comments
Labels
area/packages kind/feature New feature request triage/accepted Triage has been accepted

Comments

@infinia-yzl
Copy link
Contributor

What would you like to be added:

Please add sufficient testing for NativeChainContainer to prove that setDefiConf works as expected.

Why is this needed:

As part of migrating from the dockerode implementation to npm testcontainers #1790.

@infinia-yzl infinia-yzl added the kind/feature New feature request label Dec 19, 2022
@github-actions github-actions bot added the needs/triage Waiting for triage to be accepted label Dec 19, 2022
@github-actions
Copy link

@infinia-yzl: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the JellyfishSDK developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions github-actions bot added the needs/area Needs area label(s) label Dec 19, 2022
@github-actions
Copy link

@infinia-yzl: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the JellyfishSDK developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@fuxingloh
Copy link
Member

/triage accepted
/area packages

@github-actions github-actions bot added triage/accepted Triage has been accepted area/packages and removed needs/triage Waiting for triage to be accepted needs/area Needs area label(s) labels Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packages kind/feature New feature request triage/accepted Triage has been accepted
Projects
None yet
Development

No branches or pull requests

2 participants