-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(turbo): support extends on turbo.json
and detecting turbo to prevent re-invocation
#152
Conversation
feat(sticky-jest-turbo): detect turbo is the current process to prevent re-invocation chore(*): fix wrong lint script This PR contains breaking changes when `sticky-turbo` is used programmatically.
✅ Deploy Preview for sticky-birthday ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 67.39% 72.72% +5.33%
==========================================
Files 5 7 +2
Lines 92 176 +84
Branches 3 19 +16
==========================================
+ Hits 62 128 +66
- Misses 30 45 +15
- Partials 0 3 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I think this PR might solve this #93 |
const paths = cwd.split('/'); | ||
|
||
for (let i = 0; i < depth; i += 1) { | ||
const path = `${paths.join('/')}/turbo.json`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah maybe not because we still hardcode it to "/"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me fix this in another PR
What this PR does / why we need it:
@levaintech maintains an internal fork of sticky, this PR syncs the quality of life update that were introduced to turbo.
extends: [//]
on turbo.json, see https://turbo.build/repo/docs/core-concepts/monorepos/configuring-workspacestsconfig.json
Additional comments?:
This PR contains breaking changes when
sticky-turbo
is used programmatically.