-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use the TypeScript any
type for return types
#2402
Comments
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Not stale. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Not stale. |
Hi @jaydenseric, refactoring this particular function, would require us to also refactor all the modules for our SDK. We created an internal ticket to track this, and we’ll assess and scope the effort soon. In the meantime, we’ll keep this issue open. Thank you! |
Functions in the JS API use the TypeScript
any
type for return types. Please instead use real types so we can use these APIs with type safety.For example:
BitGoJS/modules/sdk-core/src/bitgo/wallet/wallet.ts
Line 469 in 7862547
In the mean time, it's not clear the right way to manually type this.
Feature Description
Don't use the TypeScript
any
type for return types; instead use detailed types that describe the possible variations of the real data that could be returned.Motivation
So we can use the BitGo JS SDK with type safety.
Context
N/A
The text was updated successfully, but these errors were encountered: