Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate usage of github actions/triggers to only run some CI steps on certain branches #670

Open
DominicRoyStang opened this issue Jun 14, 2021 · 0 comments
Assignees
Projects

Comments

@DominicRoyStang
Copy link
Member

DominicRoyStang commented Jun 14, 2021

The current solution for filtering on branches is not optimal since we have to write multiline bash scripts to check the current branch. We also still have to pull images for steps we end up skipping (particularly long for the deploy step since we use the Helm community builder.

As per the comment in cloudbuild.yml, this issue exists to be able to filter steps in cloudbuild.yml based on the target branch. However, this Google Bug Tracker Issue suggests to follow this guide and use a trigger.yml file instead.

I'll need to look into how this is different from GitHub actions & whether we can ensure the following:

  • Deploy steps are only run on master
  • Deploy steps don't run unless the previous ones (eg. tests/linting) passed
@DominicRoyStang DominicRoyStang created this issue from a note in To-do (To do) Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
To-do
  
To do
Development

No branches or pull requests

1 participant