Missing some config options

[GustavBroend]

Hi. I really appreciate you setting up this extension, so that the BlueOS information is available in ROS - it is very useful to my application, where we experiment with VI-SLAM underwater.

However, I think you forgot to set up a few important ROS configuations, at least for ROS Noetic. For each of the docker containers, you want to set up the environment variables, such that the containers point to the correct ROS master and publish under the correct IP. In my case, the ROS master is on a different device, so i set up my environment variables (on 192.168.2.3) accordingly.

ROS_HOSTNAME=192.168.2.2
ROS_MASTER_URI=http://192.168.2.3:11311
ROS_IP=192.168.2.2

To do so, I had to enter "pirate mode" in BlueOS and edit the extension, such that the custom settings were the following:

{
  "NetworkMode": "host",
  "HostConfig": {
	"Binds": [
  	"/dev:/dev:rw"
	],
	"Privileged": true,
	"NetworkMode": "host"
  },
  "Env": [
	"ROS_HOSTNAME=192.168.2.2",
         "ROS_MASTER_URI=http://192.168.2.3:11311",
	"ROS_IP=192.168.2.2"
  ]
}

I think you should include this in your setup guide. If you don't configure this, you can only see the topics, but you cant actually access them. Or maybe show us how we can access and configure the start.sh script?
Anyway, thought this might be useful to other Noetic users.

[patrickelectric]

Thanks for the info @GustavBroend, It's now available on our README. You can check it here.

Let us know if you have any suggestion, also be free to submit pull requests on the project.