Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gocyclo check to pipeline #120

Closed
kehoecj opened this issue Mar 25, 2024 · 4 comments · Fixed by #149
Closed

Add gocyclo check to pipeline #120

kehoecj opened this issue Mar 25, 2024 · 4 comments · Fixed by #149
Assignees
@Bhargav-InfraCloud
Labels
CI/CD CI/CD work including Github Actions good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kehoecj
Copy link
Contributor

kehoecj commented Mar 25, 2024 •
edited

Add a stage in the pipeline to run through each check in the Go Report Card
@kehoecj kehoecj added good first issue Good for newcomers help wanted Extra attention is needed CI/CD CI/CD work including Github Actions labels Mar 25, 2024
@Bhargav-InfraCloud
Copy link
Contributor

/assign

@Bhargav-InfraCloud Bhargav-InfraCloud mentioned this issue May 26, 2024
Merged
Bhargav-InfraCloud added a commit to Bhargav-InfraCloud/boeing-config-file-validator that referenced this issue May 26, 2024
@Bhargav-InfraCloud
ci(goreportcard): Add step for goreportcard check
c7ea27a 
Go report card for repo:
https://goreportcard.com/report/github.com/Boeing/config-file-validator

Fixes Boeing#120

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Bhargav-InfraCloud added a commit to Bhargav-InfraCloud/boeing-config-file-validator that referenced this issue May 26, 2024
@Bhargav-InfraCloud
ci(goreportcard): Add step for goreportcard check
09082ee 
Go report card for repo:
https://goreportcard.com/report/github.com/Boeing/config-file-validator

Fixes Boeing#120

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Bhargav-InfraCloud added a commit to Bhargav-InfraCloud/boeing-config-file-validator that referenced this issue May 26, 2024
@Bhargav-InfraCloud
ci(goreportcard): Add step for goreportcard check
d3e11ee 
Go report card for repo:
https://goreportcard.com/report/github.com/Boeing/config-file-validator

Fixes Boeing#120

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
@kehoecj
Copy link
Contributor Author

kehoecj commented May 28, 2024

Thanks for the PR @Bhargav-InfraCloud !

@ccoVeille
Copy link
Contributor

For records, I opened gojp/goreportcard#425 because goreportcard seems to be very outdated

Bhargav-InfraCloud added a commit to Bhargav-InfraCloud/boeing-config-file-validator that referenced this issue May 30, 2024
@Bhargav-InfraCloud
ci(goreportcard): Add step for goreportcard check
876f7ea 
Go report card for repo:
https://goreportcard.com/report/github.com/Boeing/config-file-validator

Fixes Boeing#120

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Bhargav-InfraCloud added a commit to Bhargav-InfraCloud/boeing-config-file-validator that referenced this issue May 30, 2024
@Bhargav-InfraCloud
ci(goreportcard): Add step for goreportcard check
0afdeaa 
Go report card for repo:
https://goreportcard.com/report/github.com/Boeing/config-file-validator

Fixes Boeing#120

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
kehoecj pushed a commit that referenced this issue May 30, 2024
@Bhargav-InfraCloud
ci(goreportcard): Add step for goreportcard check (#149)
7203891 
Go report card for repo:
https://goreportcard.com/report/github.com/Boeing/config-file-validator

Fixes #120

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
@Bhargav-InfraCloud
Copy link
Contributor

Thanks! @kehoecj 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bhargav-InfraCloud Bhargav-InfraCloud

Labels
CI/CD CI/CD work including Github Actions good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(goreportcard): Add step for goreportcard check Bhargav-InfraCloud/boeing-config-file-validator
3 participants
@ccoVeille @Bhargav-InfraCloud @kehoecj