Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x86/x86_64 assembly to list of supported languages in code blocks #4976

Open
1 task done
qbe4 opened this issue Apr 26, 2024 · 2 comments
Open
1 task done

Add x86/x86_64 assembly to list of supported languages in code blocks #4976

qbe4 opened this issue Apr 26, 2024 · 2 comments

Comments

@qbe4
Copy link

qbe4 commented Apr 26, 2024

Describe the feature you'd like

I'd like syntax highlighting for x86 and x86_64 assembly languages in code blocks.

Describe the benefits this would bring to existing BookStack users

Be able to read assembly code blocks more easily.

Can the goal of this request already be achieved via other means?

No

Have you searched for an existing open/closed issue?

  • I have searched for existing issues and none cover my fundamental request

How long have you been using BookStack?

3 months to 1 year

Additional context

There is "x86asm" in highlight.js : https://github.com/highlightjs/highlight.js/blob/main/src/languages/x86asm.js

@ssddanbrown
Copy link
Member

Thanks for the suggestion @qbe4,
Since I'm not too familiar with the forms of assembly, does the syntax highlighting here look correct?: https://codemirror.net/5/mode/gas/index.html

Saving this for my implementation reference: https://github.com/codemirror/legacy-modes/blob/main/mode/gas.js

@qbe4
Copy link
Author

qbe4 commented Apr 26, 2024

Hi @ssddanbrown, in fact the syntax used in GAS is the AT&T syntax which is quite ugly and not very used. The most commonly used syntax is the Intel syntax. To see the difference between the two : AT&T Syntax and Intel Syntax.

I doesn't have found an implementation of the Intel syntax in codemirror :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants