Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php artisan cache:clear Make sure you have the appropriate permissions #4999

Closed
2 tasks done
m4ntic0r opened this issue May 12, 2024 · 9 comments
Closed
2 tasks done

Comments

@m4ntic0r
Copy link

Attempted Debugging

  • I have read the debugging page

Searched GitHub Issues

  • I have searched GitHub for the issue.

Describe the Scenario

After updating my bookstack today to version 24.05 i see this error for the first time:

root@bookstack:/var/www/html# php artisan cache:clear i get the error: ERROR Failed to clear cache. Make sure you have the appropriate permissions.

debian 12, latest stable version. never had this before.
php artisan config:clear and php artisan view:clear without error only cache:clear with error.

checked permissions, set new permissions, tried temporary full permissions -> always this error?

Exact BookStack Version

v24.05

Log Content

No response

Hosting Environment

Debian 12, PHP8.2 fpm

@m4ntic0r
Copy link
Author

for a test i reverted my container back to 24.02 an tried again:
image

after update to 24.05:
image

@ssddanbrown
Copy link
Member

@m4ntic0r I've checked on a couple of my instances, but those clear fine. Did a quick scan of famework code for the command and cache flushing but can't see any issues.

  • Do you have any option set in your env starting with CACHE_?
  • Can you share the output of running ls -alh storage/framework/cache/data/ from your BookStack install directory?
  • Are you ever manually deleting the storage/framework/cache/data/ folder as part of your process?

@maxi322
Copy link

maxi322 commented May 13, 2024

I had the same problem yesterday when I updated my instance wich is running inside a LXC container on Proxmox.
I wanted to reproduce it today but now this command does not throw this error anymore and seems to work.

@m4ntic0r
Copy link
Author

m4ntic0r commented May 13, 2024

@ssddanbrown
only line with cache_ is:
CACHE_DRIVER=file

i dont have a data directory there.

root@bookstack:/var/www/html/storage/framework/cache# ls -lha
insgesamt 12K
drwxrwxr-x 2 www-data www-data 4,0K 12. Mai 15:51 .
drwxrwxr-x 5 www-data www-data 4,0K 31. Dez 2021 ..
-rwxrwxr-x 1 root root 20 23. Feb 2020 .gitignore
root@bookstack:/var/www/html/storage/framework/cache#

i created an empty data dir there and:
INFO Application cache cleared successfully.

@ssddanbrown
Copy link
Member

@m4ntic0r Thanks for the info and thanks @maxi322 for the confirmation.

Looks like the path did change in the last release to add the data folder, so could do with ensuring this folder exists via version control. I'll mark this to be done for the next patch release.

Dev Notes

  • Double check .gitignore addition does not conflict with cases where folder already exists
  • Will need to update parent .gitignore to ignore existing folders where existing but not added data folder (reference).

@FreeTheTech101
Copy link

Just the heads up for anyone manually making the data folder, you need to also ensure that you use chown to set the owner to www-data, or else you'll end up getting HTTP 500 errors.

@ssddanbrown
Copy link
Member

Maybe we should instead revert the folder path back then, to avoid unexpected issues with permissions.

@LordSimal
Copy link

Just had the same issue here after updating to 24.05

> @php artisan cache:clear

   ERROR  Failed to clear cache. Make sure you have the appropriate permissions.  

> @php artisan view:clear

   INFO  Compiled views cleared successfully.  

   INFO  Nothing to migrate.  

   ERROR  Failed to clear cache. Make sure you have the appropriate permissions.  

   INFO  Compiled views cleared successfully.  

The problem was fixed by creating the folder storage/framework/cache/data

ssddanbrown added a commit that referenced this issue May 18, 2024
Change made during Laravel 10 updates to align (Laravel made this change
much earlier in 5.x series) but it caused issues due to folder not
pre-existing and due to potentiall permission issues.
(CLI could create this during update, with non-compatible permissions
for webserver).

For #4999
@ssddanbrown
Copy link
Member

I've now reverted the directory change via 5651d2c, and this change will be part of a soon patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants