Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing verifications check when sponsoring #1201

Open
sentax opened this issue Feb 17, 2024 · 2 comments
Open

Missing verifications check when sponsoring #1201

sentax opened this issue Feb 17, 2024 · 2 comments

Comments

@sentax
Copy link
Contributor

sentax commented Feb 17, 2024

appThunks.js

if (missingVerifications.length) {
      const text = t(
        'apps.alert.text.missingVerification',
        'You are missing verifications: {{verifications}}.',
        {
          verifications: missingVerifications
            .map((v) => `"${verificationFriendlyName(v)}"`)
            .join(', '),
        },
      );
      dispatch(setLinkingAppError(text));
      return;
    }

this code block checks if a user has all the verifications of the app.
This revision clarifies that the code is looking for the presence of any one of the required verifications, rather than requiring all of them.

@adamstallard
Copy link
Member

adamstallard commented Mar 22, 2024

Has this been included in a pull request yet @sentax ?

@sentax
Copy link
Contributor Author

sentax commented Mar 22, 2024

Has this been included in a pull request yet @sentax ?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants