Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection on MacOS clients #365

Open
o0101 opened this issue Oct 4, 2023 · 0 comments
Open

Fix selection on MacOS clients #365

o0101 opened this issue Oct 4, 2023 · 0 comments

Comments

@o0101
Copy link
Collaborator

o0101 commented Oct 4, 2023

Issue is that the Meta key ⌘ is not correctly captured on client and transmitted as control key. It's platform-platform dependent.

This means that the control sequence that activates select depends on:

what key we capture on client,
what key we transmit to server
what key on server platform actually maps to select

We currently do not account for this, and it errors in the following way:

  • we assume server platform is linux even when it's not, so we do not transmit correct meta key sequence if running on MacOS to trigger a select
  • i'm not sure if we capture meta key correctly when we are on MacOS client (but we probably do as the web platform I think abstracts away from that by providing a Meta key which is somewhat cross-platform, encompassing ⌘ on Mac and the relevant one on other platforms).

Anyway this is one of those x-platform issues! Fun ! hahaha. And there's lots of them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant