Use the native http2 module in Node 9 #1485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-http2 is officially deprecated: molnarg/node-http2@4f174b2
Should have run prettier
|
@cristianl until node 10 is LTS, we wouldn't do this - Browsersync still technically supports back to 4 (although that should really be 6 now) |
|
@cristianl I've closed this for now since the httpModule option is intended to allow users to choose any module they have installed. I guess the only thing we'd change in terms of servers, is when we can get all of Browsersync's features working with the native http2 module we could switch to it happily. So if someone would like to open that as a separate PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-http2 is officially deprecated. The author recommends using the native http2 module that ships with Node 9.
Despite the
ExperimentalWarning: The http2 module is an experimental APIwarning in the native module, it seems more stable than node-http2. I constantly ran into an unhandled error, which crashes Browsersync.