socket.io dependency needs version bump

[garrettw]

Issue details

When I run yarn install to install something with the latest browser-sync as a dependency, I get this output:
warning browser-sync > socket.io > engine.io > uws@9.14.0: stop using this version

I noticed browser-sync is currently locked to version 2.0.4 of socket.io.
I also noticed that socket.io v2.1.0 seems to have made a change that would get rid of this warning.
So please update the socket.io dependency to v2.1.0.

Please specify which version of Browsersync, node and npm you're running

• Browsersync [ 2.24.4 ]
• Node [ 8.9.4 ]
• Npm [ 5.6.0 ]
• Yarn [ 1.6.0 ]

Affected platforms

I am on macOS but I'm sure this applies to any platform.

[rbenvenuto]

I had the same issue running yarn add browser-sync

uws's current version 10.148.0

yarn.lock

engine.io@~3.1.0:
 version "3.1.5"
  resolved "https://registry.yarnpkg.com/engine.io/-/engine.io-3.1.5.tgz#0e7ef9d690eb0b35597f1d4ad02a26ca2dba3845"
  dependencies:
    accepts "~1.3.4"
    base64id "1.0.0"
    cookie "0.3.1"
    debug "~3.1.0"
    engine.io-parser "~2.1.0"
    ws "~3.3.1"
  optionalDependencies:
    uws "~9.14.0"

Please specify which version of Browsersync, node and npm you're running

• Broserwync 2.24.4
• Node 8.8.1
• Yarn 1.5.1
• Npm 5.6.0

Affected platforms

• Ubuntu 16.04

[XhmikosR]

Any news about this?

[garrettw]

@XhmikosR It looks like it's been fixed by the commit listed above. For some reason it didn't automatically close this issue so I'll close it myself now.

[XhmikosR]

@garrettw: that isn't merged and in fact is completely broken judging from the test failures.

[garrettw]

Good point, I just looked through the test log and yeah it's definitely not finished.

[shakyShane]

@garrettw The fix is in place, it's just the jump to Mocha 4 that threw me off (needing the --exit flag) - I hope to get the release done this evening :)

[agebhar1]

Any news @shakyShane? The --exit is recommended since mocha v4.0:

The default behavior in v4.0.0 is --no-exit, where previously it was --exit.

The easiest way to “fix” the issue is to simply pass --exit to the Mocha process. It can be time-
consuming to debug–because it’s not always obvious where the problem is–but it is recommended to
do so.

I tried the latest version of mocha (5.2) which works if the --exit flag is present.