Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getClasses function's filter works contrawise #711

Open
danielcsorba opened this issue Jul 22, 2019 · 0 comments · May be fixed by #713
Open

getClasses function's filter works contrawise #711

danielcsorba opened this issue Jul 22, 2019 · 0 comments · May be fixed by #713

Comments

@danielcsorba
Copy link

bootstrap-switch/src/js/bootstrap-switch.js

Line 15 in 19275e7

].filter(v => v == null);

Result:
This currently leaving only the null values in the array. Causing invalid class names and preventing class based options to work.

Fix:
It should be negated !== instead of ==.
@danielcsorba danielcsorba changed the title getClasses function's filter work contrawise getClasses function's filter works contrawise Jul 22, 2019
@amacou amacou mentioned this issue Jul 23, 2019
Closed
amacou pushed a commit to amacou/bootstrap-switch that referenced this issue Jul 23, 2019
Fix getClasses function's filter works contrawise. Fixes Bttstrp#711
3c70032
@amacou amacou linked a pull request Jul 23, 2019 that will close this issue
Open
izumiya added a commit to sensyn-robotics/bootstrap-switch that referenced this issue Apr 17, 2023
@izumiya
fix: Bttstrp#711
6da5289
izumiya added a commit to sensyn-robotics/bootstrap-switch that referenced this issue Apr 17, 2023
@izumiya
Squashed commit of the following:
95dcb54 
commit 3c70032
Author: amacou <amano@pepabo.com>
Date:   Tue Jul 23 15:05:23 2019 +0900

    Fix getClasses function's filter works contrawise. Fixes Bttstrp#711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@danielcsorba