Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not import any images, nor canvases behind auth walls #131

Open
valioDOTch opened this issue Nov 1, 2022 · 1 comment
Open

Does not import any images, nor canvases behind auth walls #131

valioDOTch opened this issue Nov 1, 2022 · 1 comment

Comments

@valioDOTch
Copy link

valioDOTch commented Nov 1, 2022

Describe the bug
I download a .json file via the Chrome extension from a page behind an auth wall.
When I imported it to Figma all the images and canvas data on the web page is displayed as a grey box.

Expected behavior
When the extension detects that images are behind an auth wall, they are integrated into the JSON file (e.g. as base64 data URLs).

Screenshots
If applicable, add screenshots to help explain your problem.
image
image
(no, the image data isn't available "behind" that upload button)

Additional context
I took a look at the JSON.
The image URLs are noted therein, but if they're behind an auth wall, that's obviously not making any sense.
Inline SVGs were imported though.
I wouldn't mind if the plugin wouldn't do any checks, but would just have have an option which includes all images as base64 data URLs without additional network fetches (they're probably not as simple to implement).

@valioDOTch valioDOTch changed the title Does not importing any images Does not importing any images, nor canvases Nov 1, 2022
@valioDOTch valioDOTch changed the title Does not importing any images, nor canvases Does not import any images, nor canvases behind auth walls Nov 1, 2022
@iamnafets
Copy link

This is a great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants