fix(core): parent component lookup during pause #5390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the parentCtx attribute was optimized to point directly to parents with $contexts$ defined, but that broke pausing which needs the immediate parent. Co-authored-by: Jesse Zhang <jesse.zhang@orchard.com>
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
kodiakhq bot
pushed a commit
to ascorbic/unpic-img
that referenced
this pull request
Nov 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik)) | [`1.2.15` -> `1.2.17`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.2.15/1.2.17) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>BuilderIO/qwik (@​builder.io/qwik)</summary> ### [`v1.2.17`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.2.17) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.2.16...v1.2.17) ##### What's Changed - fix(labs): Better handling and visibility of q-insights.json by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5384 - feat(insights): Add new route visibility by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5385 - fix(vite): resolution of nested dependencies by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5383 - docs: fix incorrect escaping in URL by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5387 - fix(insights): improve files per cluster by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5388 - fix(qwik): Improve logging of vite plugin by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5389 - fix(core): parent component lookup during pause by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5390 - chore: clean up docs site build warnings by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5391 - docs: explain custom event props and detail when PropFunction is needed by [@​maiieul](https://togithub.com/maiieul) in [QwikDev/qwik#5386 - docs: don't index demos; don't duplicate meta descriptions by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5392 - docs: add custom 404 page by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5393 - chore(docs): small improvements to routing/index.mdx by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5395 - refactor(package.json): add docs.dev & docs.preview by [@​maiieul](https://togithub.com/maiieul) in [QwikDev/qwik#5396 - chore: 1.2.17 by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5397 **Full Changelog**: QwikDev/qwik@v1.2.16...v1.2.17 ### [`v1.2.16`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.2.16) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.2.15...v1.2.16) ##### What's Changed - docs: improve SEO with descriptions by [@​hamatoyogi](https://togithub.com/hamatoyogi) in [QwikDev/qwik#5360 - fix(cli): parseTemplatePath doesn't work in windows by [@​yuyidegit](https://togithub.com/yuyidegit) in [QwikDev/qwik#5339 - docs: fix typo by [@​mBonny87](https://togithub.com/mBonny87) in [QwikDev/qwik#5361 - chore(qwik-insights): use clientOutDir if provided by [@​intellix](https://togithub.com/intellix) in [QwikDev/qwik#5366 - docs: remove soundy.cloud by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5374 - chore: clean up release script by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5376 - fix(qwik): Incorrect module reference in inlinedQrl by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5375 - docs: Alex Russell Approved javascript framework by [@​PatrickJS](https://togithub.com/PatrickJS) in [QwikDev/qwik#5364 - chore: improved README.md for build artifacts by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5377 - fix(qwik-city): parseBody should not clone Request by [@​mpeg](https://togithub.com/mpeg) in [QwikDev/qwik#5353 - docs(eslint-rules): refactor use-method-usage to reflect current qwik… by [@​maiieul](https://togithub.com/maiieul) in [QwikDev/qwik#5344 - fix: Yarn 3/4 PnP compatibility by [@​ianlet](https://togithub.com/ianlet) in [QwikDev/qwik#5042 - revert: refactor(optimizer): remove using resolvePackageData API from Vite by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5379 - docs: update Alex Russell by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5381 - chore: 1.2.16 by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5382 ##### New Contributors - [@​yuyidegit](https://togithub.com/yuyidegit) made their first contribution in [QwikDev/qwik#5339 - [@​mBonny87](https://togithub.com/mBonny87) made their first contribution in [QwikDev/qwik#5361 - [@​ianlet](https://togithub.com/ianlet) made their first contribution in [QwikDev/qwik#5042 **Full Changelog**: QwikDev/qwik@v1.2.15...v1.2.16 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the parentCtx attribute was optimized to point directly to parents with
$contexts$defined, but that broke pausing which needs the immediate parent.Fixes #5356