fix: Bun integration env.get is undefined

[phyrog]

Overview

What is it?

• Feature / enhancement
• Bug
• Docs / tests / types / typos

Description

Fixes this error when using req.env with Bun (e.g. for qwik-auth):

TypeError: req.env.get is not a function. (In 'req.env.get("AUTH_SECRET")', 'req.env.get' is undefined)

Checklist:

• My code follows the developer guidelines of this project
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• Added new tests to cover the fix / functionality

[netlify]

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	6e494c5

[gioboa]

Thanks @phyrog 💪
This fix looks great. did you try this implementation locally?

[phyrog]

Thanks @phyrog 💪
This fix looks great. did you try this implementation locally?

Yes I did.

[gioboa]

I tested the current bun integration and it's working fine 🤔
Am I missing something?

Steps:

• pnpm create qwik@latest
• pnpm qwik add bun
• bun run build
• bun run serve
• I can see the env variable in my page

This is my /src/routes/index.tsx file

import { component$ } from "@builder.io/qwik";
import { routeLoader$ } from "@builder.io/qwik-city";

export const useEnvLoader = routeLoader$(({ env }) => env.get('TEST'))

export default component$(() => {
  const envLoader = useEnvLoader();
  return (<>{envLoader.value}</>
  );
});

[phyrog]

@gioboa Really? I'm just getting an empty page when following your instructions (works when running in dev, though). Edit: see below

Here's my system specs:

  System:
    OS: macOS 13.3.1
    CPU: (8) x64 Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz
    Memory: 17.72 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.4.0 - /usr/local/bin/node
    npm: 10.2.4 - /usr/local/bin/npm
    pnpm: 8.12.1 - ~/Library/pnpm/pnpm
    bun: 1.0.18 - ~/.bun/bin/bun
  Browsers:
    Chrome: 120.0.6099.109
    Safari: 16.4
  npmPackages:
    @builder.io/qwik: ^1.3.1 => 1.3.1
    @builder.io/qwik-city: ^1.3.1 => 1.3.1
    undici: ^5.26.0 => 5.28.2
    vite: ^5.0.6 => 5.0.10

edit: I just rebuilt again, now it shows up. However: when I change the variable after the build, it is not picked up, it will still display the old value; so I guess it gets baked into the code instead of reading at runtime?

Just my guess: When setting env: Bun.env, the env will be copied at build time (baked into the code), while with my patch, it will copy the { get(key) { Bun.env[key] }} object, which will correctly read the value at runtime.

Edit2: changing the var after building also does not work with my version 😆 But anyway, the original problem was a different one, where .get was not defined on env. I will investigate why it works with routeLoader$ but not with qwik-auth.

[phyrog]

Ok so I debugged this a bit more:

The current version works for routeLoader$ (with the above mentioned issue that it actually does not read the variable from env at runtime), but neither for routeAction$, nor globalAction$ (which is used by qwik-auth).

Reproducable the same way you posted above, but with this code in src/routes/index.tsx:

import { component$ } from "@builder.io/qwik";
import { Form, routeAction$ } from "@builder.io/qwik-city";

export const useEnv = routeAction$((_data, req) => {
  console.log(req.env.get("TEST"))
});

export default component$(() => {
  const e = useEnv()

  return (
    <>
      <Form action={e}>
        <button type="submit">Env</button>
      </Form>
    </>
  );
});

Will result in an error, same with globalAction$.

[phyrog]

@gioboa I also looked more into why it works for routeLoader$, turns out when you add bun, it automatically configures SSG, which explains why the env variable only changes after a rebuild. It is actually built into dist/q-data.json. When you disable SSG in adapters/bun/vite.config.ts, it will show the same behavior as routeAction$ and globalAction$, i.e. env.get is not a function. (In 'env.get("TEST")', 'env.get' is undefined).

[gioboa]

Thanks @phyrog for your commitment. Your change is working fine.

---

I have this other error in the terminal but it's not related to your change.
Do you have the same?

[phyrog]

@gioboa No I don't think I have seen this one