Skip to content

docs: fix entry file name #5646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2024
Merged

docs: fix entry file name #5646

merged 2 commits into from
Jan 8, 2024

Conversation

AustinGil
Copy link
Contributor

Overview

Simple change to the docs based on behavior I found in the CLI

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Docs currently mention that createQwikCity exists in /src/entry.[server].tsx, but actual behavior is in /src/entry.preview.tsx

I'm not sure about some of the other references in the rest of the page.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

netlify bot commented Dec 28, 2023

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 78ae4cb

@AustinGil AustinGil changed the title Fix entry file name docs: Fix entry file name Dec 28, 2023
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @AustinGil
If we are using node deployment, entry.[server].tsx comes in to play during production build so the docs is correct. A good improvement in this page is add deno and node-server in this phrase.

In order to deploy the server, you need to run the server/entry.[server].js file in the server of your choice, where [server] can be [express](https://expressjs.com/) or [fastify](https://fastify.dev/) **[<here>]**

and change entry.express with entry.[server] everywhere

@AustinGil
Copy link
Contributor Author

@gioboa I understand that the production build setup produces a entry.[server].tsx, but that's actually where I want to suggest a fix. This PR is specifically concerning the CSRF protection. The docs say that if you want to modify the createQwikCity options, you need to modify the src/entry.experess.tsx file (for example). What I'm saying is that createQwikCity does not exist in that file at all. In it's current form, the CLI generates a /src/entry.preview.tsx file that contains the createQwikCity. Therefore, that's the file that should be referenced in the docs, and I don't think it matters which server you actually choose.

@nelsonprsousa
Copy link
Contributor

@gioboa I understand that the production build setup produces a entry.[server].tsx, but that's actually where I want to suggest a fix. This PR is specifically concerning the CSRF protection. The docs say that if you want to modify the createQwikCity options, you need to modify the src/entry.experess.tsx file (for example). What I'm saying is that createQwikCity does not exist in that file at all. In it's current form, the CLI generates a /src/entry.preview.tsx file that contains the createQwikCity. Therefore, that's the file that should be referenced in the docs, and I don't think it matters which server you actually choose.

Actually, if you follow that page, you will end up with src/entry.express.tsx or src/entry.fastify.tsx files.

So, for someone actually reading and following this page from the start, it makes sense to have src/entry.[server].tsx, IMO. We can instead add a note regarding the /src/entry.preview.ts file. WDYT?

@AustinGil
Copy link
Contributor Author

Yeah, I get that the CLI generates a /src/entry.fastify.tsx file, but this PR is around the documentation for the CSRF protection (https://qwik.builder.io/docs/deployments/node/#csrf-protection) which says you have to change the options passed to createQwikCity in the /src/entry.express.tsx file, but this function call no longer exists in this file when you use the CLI. The function is used in /src/entry.preview.tsx. So the /src/entry.[server].tsx files are not really relevant in this context. In other words, the current state of the docs referecing the Express file is incorrect, but changing it to [server].tsx would also be incorrect.

Anyway, this was from my experience generating from the CLI at the time of opening the PR, but I think it used to be the other way.

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @AustinGil

@gioboa gioboa changed the title docs: Fix entry file name docs: fix entry file name Jan 8, 2024
@gioboa gioboa merged commit 4c4cbea into QwikDev:main Jan 8, 2024
kodiakhq bot referenced this pull request in ascorbic/unpic-img Jan 30, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik/tree/HEAD/packages/qwik)) | [`1.3.2` -> `1.4.3`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.3.2/1.4.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@builder.io%2fqwik/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@builder.io%2fqwik/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@builder.io%2fqwik/1.3.2/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@builder.io%2fqwik/1.3.2/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>BuilderIO/qwik (@&#8203;builder.io/qwik)</summary>

### [`v1.4.3`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.3)

[Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.4.2...v1.4.3)

#### What's Changed

-   chore(vite): downgrade vite version by [@&#8203;balaji-sivasakthi](https://togithub.com/balaji-sivasakthi) in [https://github.com/BuilderIO/qwik/pull/5785](https://togithub.com/BuilderIO/qwik/pull/5785)
-   fix(starter): adjust padding for 768px devices by [@&#8203;balaji-sivasakthi](https://togithub.com/balaji-sivasakthi) in [https://github.com/BuilderIO/qwik/pull/5787](https://togithub.com/BuilderIO/qwik/pull/5787)
-   chore: lint++ by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5788](https://togithub.com/BuilderIO/qwik/pull/5788)
-   fix(qwik-city): fix import ./[@&#8203;qwik-city](https://togithub.com/qwik-city) files in prod by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5791](https://togithub.com/BuilderIO/qwik/pull/5791)
-   fix(qwik-auth): lock down `@auth/core` version by [@&#8203;balazsorban44](https://togithub.com/balazsorban44) in [https://github.com/BuilderIO/qwik/pull/5790](https://togithub.com/BuilderIO/qwik/pull/5790)
-   chore(docs): align indentation by [@&#8203;greatgraphicdesign](https://togithub.com/greatgraphicdesign) in [https://github.com/BuilderIO/qwik/pull/5792](https://togithub.com/BuilderIO/qwik/pull/5792)
-   chore(docs): Update to latest builder.io/sdk-qwik by [@&#8203;STRd6](https://togithub.com/STRd6) in [https://github.com/BuilderIO/qwik/pull/5794](https://togithub.com/BuilderIO/qwik/pull/5794)
-   docs: Redirect all requests from builder.io to the qwik.dev domain. by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5796](https://togithub.com/BuilderIO/qwik/pull/5796)
-   feat(QwikCityMockProvider): add optional goto prop by [@&#8203;alexismch](https://togithub.com/alexismch) in [https://github.com/BuilderIO/qwik/pull/5779](https://togithub.com/BuilderIO/qwik/pull/5779)
-   chore(starters): update 🐼 PandaCSS integration starter dev dependency by [@&#8203;mrhoodz](https://togithub.com/mrhoodz) in [https://github.com/BuilderIO/qwik/pull/5797](https://togithub.com/BuilderIO/qwik/pull/5797)
-   feat(qwik): configure sourcemap in optimizer by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5799](https://togithub.com/BuilderIO/qwik/pull/5799)
-   chore: 1.4.3 by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5800](https://togithub.com/BuilderIO/qwik/pull/5800)

#### New Contributors

-   [@&#8203;balaji-sivasakthi](https://togithub.com/balaji-sivasakthi) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5785](https://togithub.com/BuilderIO/qwik/pull/5785)
-   [@&#8203;balazsorban44](https://togithub.com/balazsorban44) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5790](https://togithub.com/BuilderIO/qwik/pull/5790)
-   [@&#8203;greatgraphicdesign](https://togithub.com/greatgraphicdesign) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5792](https://togithub.com/BuilderIO/qwik/pull/5792)
-   [@&#8203;alexismch](https://togithub.com/alexismch) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5779](https://togithub.com/BuilderIO/qwik/pull/5779)

**Full Changelog**: QwikDev/qwik@v1.4.2...v1.4.3

### [`v1.4.2`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.2)

[Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.4.1...v1.4.2)

##### What's Changed

-   fix(docs): Sandbox playground iframe by [@&#8203;STRd6](https://togithub.com/STRd6) in [https://github.com/BuilderIO/qwik/pull/5768](https://togithub.com/BuilderIO/qwik/pull/5768)
-   docs(astro): update integration doc by [@&#8203;thejackshelton](https://togithub.com/thejackshelton) in [https://github.com/BuilderIO/qwik/pull/5771](https://togithub.com/BuilderIO/qwik/pull/5771)
-   docs: add note about Astro integrations order importance by [@&#8203;Seanmclem](https://togithub.com/Seanmclem) in [https://github.com/BuilderIO/qwik/pull/5776](https://togithub.com/BuilderIO/qwik/pull/5776)
-   feat(dev): preload modules for / so dev starts faster by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5775](https://togithub.com/BuilderIO/qwik/pull/5775)
-   fix: SW cache race condition by [@&#8203;thejackshelton](https://togithub.com/thejackshelton) in [https://github.com/BuilderIO/qwik/pull/5780](https://togithub.com/BuilderIO/qwik/pull/5780)
-   chore: 1.4.2 by [@&#8203;thejackshelton](https://togithub.com/thejackshelton) in [https://github.com/BuilderIO/qwik/pull/5781](https://togithub.com/BuilderIO/qwik/pull/5781)

##### New Contributors

-   [@&#8203;Seanmclem](https://togithub.com/Seanmclem) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5776](https://togithub.com/BuilderIO/qwik/pull/5776)

**Full Changelog**: QwikDev/qwik@v1.4.1...v1.4.2

### [`v1.4.1`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.1)

[Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.4.0...v1.4.1)

##### Overview

-   Try harder to prevent dirty tasks on SSR
-   AWS middleware in `qwik-city`
-   File filter option to make Qwik work better with Astro
-   `qwik-auth` can now handle multiple cookies
-   Node adapters in `qwik-city` now read .env files
-   Bugfixes in various service workers, starter CSS build, etc
-   Dependency updates

Thanks to all contributors!

##### Commits

-   chore(starters): update 🐼 PandaCSS integration dev dependency  by [@&#8203;mrhoodz](https://togithub.com/mrhoodz) in [https://github.com/BuilderIO/qwik/pull/5739](https://togithub.com/BuilderIO/qwik/pull/5739)
-   docs: add Valibot website to showcases by [@&#8203;fabian-hiller](https://togithub.com/fabian-hiller) in [https://github.com/BuilderIO/qwik/pull/5740](https://togithub.com/BuilderIO/qwik/pull/5740)
-   fix: multiple cookies in qwik-auth by [@&#8203;ksjogo](https://togithub.com/ksjogo) in [https://github.com/BuilderIO/qwik/pull/5602](https://togithub.com/BuilderIO/qwik/pull/5602)
-   feat(qwik-city): AWS adapter middleware by [@&#8203;leifermendez](https://togithub.com/leifermendez) in [https://github.com/BuilderIO/qwik/pull/5732](https://togithub.com/BuilderIO/qwik/pull/5732)
-   docs: fix code highlight by downgrading rehype-pretty-code by [@&#8203;Balastrong](https://togithub.com/Balastrong) in [https://github.com/BuilderIO/qwik/pull/5742](https://togithub.com/BuilderIO/qwik/pull/5742)
-   feat(starters): add dotenv in node adapters by [@&#8203;hassanzohdy](https://togithub.com/hassanzohdy) in [https://github.com/BuilderIO/qwik/pull/5749](https://togithub.com/BuilderIO/qwik/pull/5749)
-   fix(docs): Validate origin on postmessage by [@&#8203;STRd6](https://togithub.com/STRd6) in [https://github.com/BuilderIO/qwik/pull/5751](https://togithub.com/BuilderIO/qwik/pull/5751)
-   feat(vite): new file filter option by [@&#8203;thejackshelton](https://togithub.com/thejackshelton) in [https://github.com/BuilderIO/qwik/pull/5752](https://togithub.com/BuilderIO/qwik/pull/5752)
-   fix(ssr): dirty tasks by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5741](https://togithub.com/BuilderIO/qwik/pull/5741)
-   fix(qwik): ensure that SW cache is properly opened by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5748](https://togithub.com/BuilderIO/qwik/pull/5748)
-   fix: insights error handling and qwik-city json imports by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5754](https://togithub.com/BuilderIO/qwik/pull/5754)
-   fix(prefetch-sw): await cache opening by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5759](https://togithub.com/BuilderIO/qwik/pull/5759)
-   chore: updates by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5760](https://togithub.com/BuilderIO/qwik/pull/5760)
-   fix(sw-prefetch): prevent uninitialized cache use by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5761](https://togithub.com/BuilderIO/qwik/pull/5761)
-   fix(sw-prefetch): cache handling by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5764](https://togithub.com/BuilderIO/qwik/pull/5764)
-   fix: duplicated css code in global.css in starter template by [@&#8203;linkfang](https://togithub.com/linkfang) in [https://github.com/BuilderIO/qwik/pull/5763](https://togithub.com/BuilderIO/qwik/pull/5763)
-   feat(repl): use bundled qwik and prettier versions by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5755](https://togithub.com/BuilderIO/qwik/pull/5755)
-   fix(sw-prefetch): clone on reuse by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5765](https://togithub.com/BuilderIO/qwik/pull/5765)
-   chore: 1.4.1 by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5766](https://togithub.com/BuilderIO/qwik/pull/5766)

##### New Contributors

-   [@&#8203;STRd6](https://togithub.com/STRd6) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5751](https://togithub.com/BuilderIO/qwik/pull/5751)

**Full Changelog**: QwikDev/qwik@v1.4.0...v1.4.1

### [`v1.4.0`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.0)

[Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.3.5...v1.4.0)

##### What's Changed

-   Types have changed a bit, now JSX components output `JSXOutput` instead of `JSXNode`, which captures the existing possibility to return strings, booleans, arrays etc.
-   The Link component now automatically prefetches the JS needed
-   When SPA routing fails, it will now use MPA routing as a fallback
-   Various bugfixes

##### PRs merged

-   docs(showcase): add Blueagle's Profolio & Blog by [@&#8203;blueagler](https://togithub.com/blueagler) in [https://github.com/BuilderIO/qwik/pull/5695](https://togithub.com/BuilderIO/qwik/pull/5695)
-   docs(showcase): update metrics by [@&#8203;gioboa](https://togithub.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5707](https://togithub.com/BuilderIO/qwik/pull/5707)
-   fix(types): untyped components, test more edge cases by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5713](https://togithub.com/BuilderIO/qwik/pull/5713)
-   docs(showcase): add Zhou's portfolio by [@&#8203;linkfang](https://togithub.com/linkfang) in [https://github.com/BuilderIO/qwik/pull/5710](https://togithub.com/BuilderIO/qwik/pull/5710)
-   chore: upgrades by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5705](https://togithub.com/BuilderIO/qwik/pull/5705)
-   fix(qwik): register new index.d.ts package file by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5715](https://togithub.com/BuilderIO/qwik/pull/5715)
-   docs: move props example after local state and useStore explanation by [@&#8203;Balastrong](https://togithub.com/Balastrong) in [https://github.com/BuilderIO/qwik/pull/5718](https://togithub.com/BuilderIO/qwik/pull/5718)
-   docs: emphasize on useStore and onInput$ by [@&#8203;Balastrong](https://togithub.com/Balastrong) in [https://github.com/BuilderIO/qwik/pull/5719](https://togithub.com/BuilderIO/qwik/pull/5719)
-   docs: add Storybook Examples by [@&#8203;thenhawke](https://togithub.com/thenhawke) in [https://github.com/BuilderIO/qwik/pull/5720](https://togithub.com/BuilderIO/qwik/pull/5720)
-   fix(jsx-qwik-attributes): fix ts error TS4023 by [@&#8203;maiieul](https://togithub.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5722](https://togithub.com/BuilderIO/qwik/pull/5722)
-   fix(types): JSX.Element is JSXOutput by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5723](https://togithub.com/BuilderIO/qwik/pull/5723)
-   fix: prevent race condition by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5711](https://togithub.com/BuilderIO/qwik/pull/5711)
-   fix: build from scratch + insights by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5724](https://togithub.com/BuilderIO/qwik/pull/5724)
-   docs: Good first issue link doesn't lead you to properly label "COMMUNITY:  good first issue" by [@&#8203;aendel](https://togithub.com/aendel) in [https://github.com/BuilderIO/qwik/pull/5726](https://togithub.com/BuilderIO/qwik/pull/5726)
-   docs: fixed CodeSandbox/CodeFile src paths to match github files by [@&#8203;aendel](https://togithub.com/aendel) in [https://github.com/BuilderIO/qwik/pull/5725](https://togithub.com/BuilderIO/qwik/pull/5725)
-   fix: Uppercase handling for SameSite cookie values by [@&#8203;ksjogo](https://togithub.com/ksjogo) in [https://github.com/BuilderIO/qwik/pull/5603](https://togithub.com/BuilderIO/qwik/pull/5603)
-   feat(link): prefetch symbols by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5480](https://togithub.com/BuilderIO/qwik/pull/5480)
-   docs: Fixed various typos (or misspelled words) in documentation files by [@&#8203;aendel](https://togithub.com/aendel) in [https://github.com/BuilderIO/qwik/pull/5728](https://togithub.com/BuilderIO/qwik/pull/5728)
-   chore: extra type tests by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5580](https://togithub.com/BuilderIO/qwik/pull/5580)
-   fix(build): qwik binary path in package.json by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5729](https://togithub.com/BuilderIO/qwik/pull/5729)
-   fix(routing): fallback to hard navigation when soft navigation fails. by [@&#8203;iamriajul](https://togithub.com/iamriajul) in [https://github.com/BuilderIO/qwik/pull/5521](https://togithub.com/BuilderIO/qwik/pull/5521)
-   fix(JSX): remove Promise from FC by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5730](https://togithub.com/BuilderIO/qwik/pull/5730)
-   fix(core): serialize the 'key' attribute of JSX nodes by [@&#8203;yanivhamo](https://togithub.com/yanivhamo) in [https://github.com/BuilderIO/qwik/pull/5501](https://togithub.com/BuilderIO/qwik/pull/5501)
-   fix(repl): give monaco the names of the imports by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5734](https://togithub.com/BuilderIO/qwik/pull/5734)
-   docs(cookbook): add Combine Request Handlers example by [@&#8203;gioboa](https://togithub.com/gioboa) and [@&#8203;erikras](https://togithub.com/erikras) in [https://github.com/BuilderIO/qwik/pull/5733](https://togithub.com/BuilderIO/qwik/pull/5733)
-   fix(docs): grammar in "Project Structure" page by [@&#8203;ChallengeHandler](https://togithub.com/ChallengeHandler) in [https://github.com/BuilderIO/qwik/pull/5735](https://togithub.com/BuilderIO/qwik/pull/5735)
-   chore: 1.4.0 by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5736](https://togithub.com/BuilderIO/qwik/pull/5736)

##### New Contributors

-   [@&#8203;blueagler](https://togithub.com/blueagler) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5695](https://togithub.com/BuilderIO/qwik/pull/5695)
-   [@&#8203;linkfang](https://togithub.com/linkfang) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5710](https://togithub.com/BuilderIO/qwik/pull/5710)
-   [@&#8203;Balastrong](https://togithub.com/Balastrong) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5718](https://togithub.com/BuilderIO/qwik/pull/5718)
-   [@&#8203;thenhawke](https://togithub.com/thenhawke) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5720](https://togithub.com/BuilderIO/qwik/pull/5720)
-   [@&#8203;aendel](https://togithub.com/aendel) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5726](https://togithub.com/BuilderIO/qwik/pull/5726)
-   [@&#8203;ksjogo](https://togithub.com/ksjogo) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5603](https://togithub.com/BuilderIO/qwik/pull/5603)
-   [@&#8203;yanivhamo](https://togithub.com/yanivhamo) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5501](https://togithub.com/BuilderIO/qwik/pull/5501)
-   [@&#8203;ChallengeHandler](https://togithub.com/ChallengeHandler) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5735](https://togithub.com/BuilderIO/qwik/pull/5735)

**Full Changelog**: QwikDev/qwik@v1.3.5...v1.4.0

### [`v1.3.5`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.3.5)

[Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.3.4...v1.3.5)

#### What's Changed

-   docs: fix typos for theme management cookbook by [@&#8203;harshmangalam](https://togithub.com/harshmangalam) in [https://github.com/BuilderIO/qwik/pull/5698](https://togithub.com/BuilderIO/qwik/pull/5698)
-   fix(labs): double slash when used with BASE_URL by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5700](https://togithub.com/BuilderIO/qwik/pull/5700)
-   fix: improve escapeText and unescapeText replace to prevent XSS by [@&#8203;ignatvilesov](https://togithub.com/ignatvilesov) in [https://github.com/BuilderIO/qwik/pull/5701](https://togithub.com/BuilderIO/qwik/pull/5701)
-   chore: allow any undici version by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5703](https://togithub.com/BuilderIO/qwik/pull/5703)
-   docs(propfunctionprops): mark propfunctionprops as deprecated by [@&#8203;maiieul](https://togithub.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5680](https://togithub.com/BuilderIO/qwik/pull/5680)
-   chore: 1.3.5 by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5704](https://togithub.com/BuilderIO/qwik/pull/5704)

**Full Changelog**: QwikDev/qwik@v1.3.4...v1.3.5

### [`v1.3.4`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.3.4)

[Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.3.3...v1.3.4)

##### What's Changed

-   chore: update deps + monaco by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5685](https://togithub.com/BuilderIO/qwik/pull/5685)
-   chore: Remove duplicated dist directory from .prettierignore by [@&#8203;nelsonprsousa](https://togithub.com/nelsonprsousa) in [https://github.com/BuilderIO/qwik/pull/5687](https://togithub.com/BuilderIO/qwik/pull/5687)
-   docs: add og-img integration guide by [@&#8203;fabian-hiller](https://togithub.com/fabian-hiller) in [https://github.com/BuilderIO/qwik/pull/5686](https://togithub.com/BuilderIO/qwik/pull/5686)
-   chore: improve FunctionComponent by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5688](https://togithub.com/BuilderIO/qwik/pull/5688)
-   fix: improve escapeText replace by [@&#8203;ignatvilesov](https://togithub.com/ignatvilesov) in [https://github.com/BuilderIO/qwik/pull/5689](https://togithub.com/BuilderIO/qwik/pull/5689)
-   fix(optimizer): use correct prop in omit by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5690](https://togithub.com/BuilderIO/qwik/pull/5690)
-   chore: 1.3.4 by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5691](https://togithub.com/BuilderIO/qwik/pull/5691)
-   docs: fix typos for nav link cookbook  by [@&#8203;harshmangalam](https://togithub.com/harshmangalam) in [https://github.com/BuilderIO/qwik/pull/5694](https://togithub.com/BuilderIO/qwik/pull/5694)

##### New Contributors

-   [@&#8203;ignatvilesov](https://togithub.com/ignatvilesov) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5689](https://togithub.com/BuilderIO/qwik/pull/5689)

**Full Changelog**: QwikDev/qwik@v1.3.3...v1.3.4

### [`v1.3.3`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.3.3)

[Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.3.2...v1.3.3)

##### What's Changed

-   fix(cli): Update jokes.json by [@&#8203;mayank99](https://togithub.com/mayank99) in [https://github.com/BuilderIO/qwik/pull/5657](https://togithub.com/BuilderIO/qwik/pull/5657)
-   docs: for accessing the .env variables in serverfull architechture example in express by [@&#8203;sreeisalso](https://togithub.com/sreeisalso) in [https://github.com/BuilderIO/qwik/pull/5619](https://togithub.com/BuilderIO/qwik/pull/5619)
-   docs: change placement of {...props}  and add section by [@&#8203;Adbib](https://togithub.com/Adbib) in [https://github.com/BuilderIO/qwik/pull/5664](https://togithub.com/BuilderIO/qwik/pull/5664)
-   docs: Update build command in Static Site Generation (SSG) Overview docs by [@&#8203;lelouchB](https://togithub.com/lelouchB) in [https://github.com/BuilderIO/qwik/pull/5668](https://togithub.com/BuilderIO/qwik/pull/5668)
-   fix(starter): rename tailwind postcss.config file by [@&#8203;iamriajul](https://togithub.com/iamriajul) in [https://github.com/BuilderIO/qwik/pull/5669](https://togithub.com/BuilderIO/qwik/pull/5669)
-   fix: fixing running qwik-development-server on windows machine by [@&#8203;hassanzohdy](https://togithub.com/hassanzohdy) in [https://github.com/BuilderIO/qwik/pull/5593](https://togithub.com/BuilderIO/qwik/pull/5593)
-   fix(starter): add vite plugin type by [@&#8203;iamriajul](https://togithub.com/iamriajul) in [https://github.com/BuilderIO/qwik/pull/5670](https://togithub.com/BuilderIO/qwik/pull/5670)
-   feat(qwik-react): directive aliases for Astro and other package conflicts by [@&#8203;thejackshelton](https://togithub.com/thejackshelton) in [https://github.com/BuilderIO/qwik/pull/5651](https://togithub.com/BuilderIO/qwik/pull/5651)
-   feat: qwik-prefetch-worker by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5618](https://togithub.com/BuilderIO/qwik/pull/5618)
-   refactor: Clarify var naming qwikloader.ts by [@&#8203;gabrielgrant](https://togithub.com/gabrielgrant) in [https://github.com/BuilderIO/qwik/pull/5546](https://togithub.com/BuilderIO/qwik/pull/5546)
-   docs: fix entry file name by [@&#8203;AustinGil](https://togithub.com/AustinGil) in [https://github.com/BuilderIO/qwik/pull/5646](https://togithub.com/BuilderIO/qwik/pull/5646)
-   feat(labs): Support base prefix in untypedAppUrl by [@&#8203;tera-ny](https://togithub.com/tera-ny) in [https://github.com/BuilderIO/qwik/pull/5615](https://togithub.com/BuilderIO/qwik/pull/5615)
-   style(starter templates): updates to starter templates names by [@&#8203;abstractalgo](https://togithub.com/abstractalgo) in [https://github.com/BuilderIO/qwik/pull/5479](https://togithub.com/BuilderIO/qwik/pull/5479)
-   fix: Clearer error message for `resolveValue` for `head` function by [@&#8203;colelawrence](https://togithub.com/colelawrence) in [https://github.com/BuilderIO/qwik/pull/5624](https://togithub.com/BuilderIO/qwik/pull/5624)
-   refactor(starter): add alt attribute in order to improve accessibility by [@&#8203;tidiview](https://togithub.com/tidiview) in [https://github.com/BuilderIO/qwik/pull/5674](https://togithub.com/BuilderIO/qwik/pull/5674)
-   refactor(insights): remove netlify.toml causing confusion by [@&#8203;mhevery](https://togithub.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5676](https://togithub.com/BuilderIO/qwik/pull/5676)
-   feat(cookbook): add Algolia search by [@&#8203;gioboa](https://togithub.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5675](https://togithub.com/BuilderIO/qwik/pull/5675)
-   fix(cookbook): change Algolia example by [@&#8203;gioboa](https://togithub.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5677](https://togithub.com/BuilderIO/qwik/pull/5677)
-   fix: polymorphic component types by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5672](https://togithub.com/BuilderIO/qwik/pull/5672)
-   chore: add Nix build flake environment by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5594](https://togithub.com/BuilderIO/qwik/pull/5594)
-   fix(nix): missing .envrc by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5678](https://togithub.com/BuilderIO/qwik/pull/5678)
-   fix(nix): make rust and wasm builds work by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5679](https://togithub.com/BuilderIO/qwik/pull/5679)
-   fix: dynamic refs by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5681](https://togithub.com/BuilderIO/qwik/pull/5681)
-   fix(core): Make polymorphic components easy by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5682](https://togithub.com/BuilderIO/qwik/pull/5682)
-   chore: 1.3.3 by [@&#8203;wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5683](https://togithub.com/BuilderIO/qwik/pull/5683)

##### New Contributors

-   [@&#8203;mayank99](https://togithub.com/mayank99) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5657](https://togithub.com/BuilderIO/qwik/pull/5657)
-   [@&#8203;lelouchB](https://togithub.com/lelouchB) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5668](https://togithub.com/BuilderIO/qwik/pull/5668)
-   [@&#8203;hassanzohdy](https://togithub.com/hassanzohdy) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5593](https://togithub.com/BuilderIO/qwik/pull/5593)
-   [@&#8203;AustinGil](https://togithub.com/AustinGil) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5646](https://togithub.com/BuilderIO/qwik/pull/5646)
-   [@&#8203;tera-ny](https://togithub.com/tera-ny) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5615](https://togithub.com/BuilderIO/qwik/pull/5615)

**Full Changelog**: QwikDev/qwik@v1.3.2...v1.3.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants