docs(speculative-module-fetching): remove that it doesn't work in preview because it does #5836
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…view because it does
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
|
Looks good! Merging. |
kodiakhq bot
referenced
this pull request
in ascorbic/unpic-img
Feb 18, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik/tree/HEAD/packages/qwik)) | [`1.4.4` -> `1.4.5`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.4.4/1.4.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>BuilderIO/qwik (@​builder.io/qwik)</summary> ### [`v1.4.5`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.5) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.4.4...v1.4.5) #### What's Changed - docs: Fix broken Markdown on Astro Docs page by [@​LorisSigrist](https://togithub.com/LorisSigrist) in [https://github.com/BuilderIO/qwik/pull/5830](https://togithub.com/BuilderIO/qwik/pull/5830) - fix: qwik-react peer version by [@​wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5831](https://togithub.com/BuilderIO/qwik/pull/5831) - docs: update index.mdx to account for bun start crash on win by [@​codethinki](https://togithub.com/codethinki) in [https://github.com/BuilderIO/qwik/pull/5834](https://togithub.com/BuilderIO/qwik/pull/5834) - docs(speculative-module-fetching): remove that it doesn't work in preview because it does by [@​maiieul](https://togithub.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5836](https://togithub.com/BuilderIO/qwik/pull/5836) - fix(qwik-city): don't cache errors by [@​wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5839](https://togithub.com/BuilderIO/qwik/pull/5839) - docs(showcase): added Sasthya Seba - Healthcare service provider. by [@​iamriajul](https://togithub.com/iamriajul) in [https://github.com/BuilderIO/qwik/pull/5838](https://togithub.com/BuilderIO/qwik/pull/5838) - chore: Update 🐼 PandaCSS integration dev dependenc by [@​mrhoodz](https://togithub.com/mrhoodz) in [https://github.com/BuilderIO/qwik/pull/5842](https://togithub.com/BuilderIO/qwik/pull/5842) - fix(ssr): task sorting during SSR by [@​wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5847](https://togithub.com/BuilderIO/qwik/pull/5847) - chore: 1.4.5 by [@​wmertens](https://togithub.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5848](https://togithub.com/BuilderIO/qwik/pull/5848) #### New Contributors - [@​LorisSigrist](https://togithub.com/LorisSigrist) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5830](https://togithub.com/BuilderIO/qwik/pull/5830) - [@​codethinki](https://togithub.com/codethinki) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5834](https://togithub.com/BuilderIO/qwik/pull/5834) **Full Changelog**: QwikDev/qwik@v1.4.4...v1.4.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOTEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE5MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is it?
Description
I tested in a fresh qwik app and speculative module fetching appears to be working in preview.
To verify, just install a qwik starter project with the flower and todos. On the home page click on the + button of the counter on a fresh page and you'll see that the signal code is being retrieved from the service worker.
Checklist: