fix(qwik-loader): run only once + better minify #5876
Merged
+58
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wmertens
commented
Feb 22, 2024
wmertens
commented
- only run once in the browser
- qEvents is no longer used
- qwikloader.optimize.js is the same as regular, remove
- some tricks to allow smaller code after minify
- remove @vite-ignore comment
✅ Deploy Preview for qwik-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wmertens
force-pushed
the
build/qwik-loader-fix
branch
from
26d696a to
9195baa
Compare
Deploying with
|
| Latest commit: |
7c040e2
|
| Status: | 🚫 Build failed. |
- qEvents is no longer used - qwikloader.optimize.js is the same as regular, remove - some tricks to allow smaller code after minify - remove @vite-ignore comment
wmertens
force-pushed
the
build/qwik-loader-fix
branch
from
9195baa to
7c040e2
Compare
mhevery
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.