fix(docker): fix Docker build failing #5892
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker build was failing from one of wasm-pack's dependencies requiring a newer version of rustc than was provided by the container. I passed the --locked flag to the cargo install command so that the rust packages use their cargo.lock files if available to ensure more reproducible builds. fixes QwikDev#5891 fix QwikDev#5891
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix #5891
What is it?
Description
Docker build was failing from one of
wasm-pack's dependencies requiring a newer version ofrustcthan was provided by the container. I passed the--lockedflag to thecargo installcommand so that the rust packages use theircargo.lockfiles if available to ensure more reproducible builds.Note: Another possible fix for #5891 is to upgrade the container's rust toolchain version to >= v1.74 in the docker container. I chose not to use this solution since I'm not familiar with the rust toolchain and I could not determine the possible side effects of upgrading the toolchain version which could possibly contain breaking changes.
Use cases and why
Docker is convenient for creating reproducible builds and streamlining the contribution process. This fix allows Docker to be used again and in a more reproducible manner than before.
Checklist: