fix(core): spread props, className #5998
Merged
+182
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the deprecation warnings suffice, no need for extra handling, especially since some users report not being able to avoid it.
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
mhevery
approved these changes
Mar 12, 2024
gioboa
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{...props}overridingIt works by, when a component has spread props (
dynamic_componentistrue), putting all props in the mutable props and tagging them as immutable by also setting their key in the immutable props to _IMMUTABLE.Then, in SSR and DOM, the visitors are changed to give precedence to immutable props when both mutable and immutable are defined.