Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix README badges #6021

Merged
merged 1 commit into from
Mar 22, 2024
Merged

docs: Fix README badges #6021

merged 1 commit into from
Mar 22, 2024

Conversation

rerelurelu
Copy link
Contributor

Overview

スクリーンショット 2024-03-16 17 29 17

  • Remove Vercel Server badge
  • Add Vercel Serverless badge
  • Add Vercel Edge budge

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

As mentioned Overview.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Mar 16, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0bf7fdb

@gioboa
Copy link
Member

gioboa commented Mar 18, 2024

I tested this change but it's showing "failing" 🤔

image

@rerelurelu
Copy link
Contributor Author

I tested this change but it's showing "failing"

It's showing up because the Vercel Edge and Vercel Serverless workflows are failing.
Neither of these errors is caused by this PR.

@wmertens wmertens merged commit d8b5210 into QwikDev:main Mar 22, 2024
22 checks passed
@wmertens
Copy link
Member

Thanks! I don't suppose you can fix the workflows? ;-)

@wmertens
Copy link
Member

So the serverless workflow fails here https://github.com/BuilderIO/qwik-city-e2e/actions/runs/8362101976/job/22891855652#step:8:26

and the edge workflow was disabled 8 months ago 🤔

@wmertens
Copy link
Member

wmertens commented Mar 22, 2024

ok the qwik-city branch of the workflows is behind, that's why. Added a PR QwikDev/qwik-city-e2e#10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants