Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: less and stylus support in development #6055

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

sotasan
Copy link
Contributor

@sotasan sotasan commented Mar 26, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Less and Styles did not work with development server, because these extensions were missing.

Use cases and why

  • Less and Stylus should work in development.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Mar 26, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c068220

@wmertens
Copy link
Member

So just to understand, nothing else is needed right? Vite just supports it?

@sotasan
Copy link
Contributor Author

sotasan commented Mar 26, 2024

So just to understand, nothing else is needed right? Vite just supports it?

Yeah, it was just not injected in the dev server.

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sotasan

@gioboa gioboa merged commit 2593bc6 into QwikDev:main Mar 27, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants