Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(starters): use latest qwik sdk in starters and fixes #6061

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

sidmohanty11
Copy link
Contributor

@sidmohanty11 sidmohanty11 commented Mar 27, 2024

Overview

This PR upgrades the version of qwik sdk as well as qwik dev tools to their latest in builder_io integration starters. This also fixes couple of issues:

  • Uses latest SDK functions (fetchOneEntry, Content)
  • Fixes the Counter component by adding the missing Gauge component

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Loom

https://www.loom.com/share/de19fe84f7fb400f9566b95f77a2738c

Use cases and why

    1. Unblocks user to smoothly onboard using the builder.io integration

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Mar 27, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 33cfcd6

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit about the gauge, can you fix?

LGTM

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidmohanty11 great 👏

@PatrickJS PatrickJS merged commit 3ea024f into QwikDev:main Mar 30, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants