Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve example in middleware doc #6065

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

plakatari
Copy link
Contributor

@plakatari plakatari commented Mar 28, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

The example code for the send() function in the middleware documentation was wrong.

Use cases and why

  • Documentation should be correct

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Mar 28, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5ae8142

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old code is ok, the new way is just a sugar syntax. It looks ok to me @plakatari

@gioboa gioboa changed the title Fix example for send() in middleware doc docs: improve example in middleware doc Mar 28, 2024
@gioboa gioboa added the COMP: docs Improvements or additions to documentation label Mar 28, 2024
@gioboa gioboa enabled auto-merge (squash) March 28, 2024 19:43
@gioboa gioboa disabled auto-merge March 28, 2024 19:43
@gioboa gioboa enabled auto-merge (squash) March 28, 2024 19:44
@gioboa gioboa merged commit e9ebce1 into QwikDev:main Mar 28, 2024
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants