docs: re-add OnThisPage for docs pages #6095
Merged
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
gioboa
requested changes
Apr 6, 2024
gioboa
changed the title
gioboa
changed the title
gioboa
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Re-add OnThisPage for docs pages (removed by mistake).
See #6073 (comment) and following discussion.
@shairez
I replaced your fix for horizontal scrolling on mobile with
min-w-48on.docs-containerto mitigate possible issues on larger screens as well. Unfortunately, I didn't figure out why the code fragments messed up themin-contentvalue in the first place.Checklist:
I have made corresponding changes to the documentationAdded new tests to cover the fix / functionality