Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smpt server for password emails #59

Open
Buuntu opened this issue Jun 3, 2020 · 5 comments
Open

Add smpt server for password emails #59

Buuntu opened this issue Jun 3, 2020 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Buuntu
Copy link
Owner

Buuntu commented Jun 3, 2020

There should be routes that trigger an email for "forgot" and "reset" password options. These can be celery tasks but probably need a separate container for a simple SMTP server in order to send the emails.

The fullstack Vue project has an example of a containerized SMTP server.

@Buuntu Buuntu added enhancement New feature or request good first issue Good for newcomers labels Jun 3, 2020
@F1r3Hydr4nt
Copy link
Contributor

F1r3Hydr4nt commented Jun 4, 2020

The fullstack Vue app relies on a third party provider, but contains all the code to implement that. You need a signup page, I sort of threw one together earlier but didn't implement the endpoint yet. Just getting used to the cookiecutting so far, do I merely add the changes to the dev repo to the cookie cutter top level when they work?

@Buuntu
Copy link
Owner Author

Buuntu commented Jun 4, 2020

Thanks, if you want to take a stab at it that would be great! For the signup page, you can probably just reuse the login page with a few changes. Do you want me to assign this ticket to you?

Yeah for the SMTP server, the simpler the better. The Vue project has lots of email templates and might be overly complex for this, but if it's easy to copy+paste that is fine.

So the way I've been doing it for local development, which may not be the best way, is to make the changes at the top level and then run ./scripts/test_local.sh. It takes a minute to generate and start the docker-compose files but then you can see the changes in your local server once it does since this both starts the docker containers and runs all of the tests. I am curious myself if there is a better way to do this though, I think that's how the Vue project is setup and I haven't been able to find a better suggestion in the cookiecutter docs. The time it takes to build webpack is also very slow so it's not ideal.

For frontend stuff what you suggested might be better since this iteration cycle can take a while. For the backend it's a bit better since you can just write tests and they are very quick to run.

@F1r3Hydr4nt
Copy link
Contributor

I can take a look at implementing a 'signup' endpoint and associated form page, sure!

@pigeonflight
Copy link

What's the status of this? @freddiehonohan @Buuntu

@JasonHoku
Copy link
Contributor

@pigeonflight a quick fix option for now, as I've done in other works could be configuring EmailJS with gmail SMTP to read and send variables from react.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants