Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect http.sslVerify #1109

Open
jalil-salame opened this issue Nov 13, 2023 · 5 comments
Open

Respect http.sslVerify #1109

jalil-salame opened this issue Nov 13, 2023 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jalil-salame
Copy link
Contributor

Summary 💡

I need to ignore the validity of SSL certificates (corporate proxy so security is "not a concern").

Motivation 🔦

As mentioned in #1103 (comment). I use git/gix behind a corporate proxy which has a self-signed certificate. To use gix there I need to either not verify the certificates, or to respect the configured certificates on windows (this is not done by git/curl so I would not personally pursue this path).

@jalil-salame jalil-salame added the enhancement New feature or request label Nov 13, 2023
@Byron Byron changed the title Respect http.sslVerify Respect http.sslVerify when using the max-pure feature Nov 13, 2023
@Byron Byron changed the title Respect http.sslVerify when using the max-pure feature Respect http.sslVerify Nov 13, 2023
@Byron
Copy link
Owner

Byron commented Nov 13, 2023

It turns out that gix knows the following about that:

❯ gix config-tree | rg sslVerify
 🤔   http.sslVerify                                       not planned ℹ on demand ℹ  

It's indeed not implemented even for the curl backend, and doing so should be straightforward to wire up.
Please note that in the max-pure configuration, most of the http options aren't supported, as it needs a completely separate implementation given that it relies on reqwest.

@Byron Byron added the help wanted Extra attention is needed label Nov 13, 2023
@dirthsj
Copy link

dirthsj commented Nov 14, 2023

or to respect the configured certificates on windows (this is not done by git/curl so I would not personally pursue this path).

Note that this does work with git under the following option;

git config --global http.sslBackend schannel

I would hope gix can also respect this setting eventually (maybe that's a separate issue though).

@Byron
Copy link
Owner

Byron commented Nov 14, 2023

Thanks for sharing!

I am quite sure that eventually this will be implemented as gix has a real opportunity to be more compatible to Windows than git is.

@Alvenix
Copy link
Contributor

Alvenix commented Dec 4, 2023

As 1142 was merged, gix now respect sslVerify for the curl http backend.

@Byron
Copy link
Owner

Byron commented Dec 4, 2023

I second that, and add that the curl backend corresponds to the max version of gix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants