Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a crates folder #1200

Open
Tudyx opened this issue Dec 21, 2023 · 1 comment
Open

Consider a crates folder #1200

Tudyx opened this issue Dec 21, 2023 · 1 comment
Labels
acknowledged an issue is accepted as shortcoming to be fixed help wanted Extra attention is needed

Comments

@Tudyx
Copy link

Tudyx commented Dec 21, 2023

I'm huge fan of your work, so I regulary send link to this repo to my friends and coroworkers. Sadly, the first reaction I get is that people are kind of a afraid by the number of folders at the root of the project. I think it could also be intimidating for new contributors.
One possible solution is to use a crates folder as described in the Matklad blog post. Rust analyzer and a lot of other project use this.
I'm aware this will break a lot of PR to do this, but as the project raise in popularity the sooner is the better.

@Byron Byron changed the title Considering a crates folder Consider a crates folder Dec 21, 2023
@Byron
Copy link
Owner

Byron commented Dec 21, 2023

Thank you ☺️!

I was thinking the same, but what keeps me from moving folders is the requirement of cargo-smart-release to track changes to crates through the git history. Right now it has very limited rename tracking, but would have to learn to deal with the move into the crates folder.

The code for this is here, so it's not a lot and it should be possible to retrofit it with the ability to deal with movements into crates (even though from its perspective, it moves out of crates into the root folder as it traverses backwards through time).

It would sure be nice have a new 'face' for the projects first impression for the beginning of next year, let's see if I can make it happen.

@Byron Byron added help wanted Extra attention is needed acknowledged an issue is accepted as shortcoming to be fixed labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged an issue is accepted as shortcoming to be fixed help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants