Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing closing backtick in gix lib documentation #1325

Merged
merged 2 commits into from Mar 19, 2024

Conversation

kdelorey
Copy link
Contributor

This is a silly and very simple change to just correct a formatting mistake in the documentation of the gix crate.

You can see the formatting error on the docs.rs documentation. Put simply, an opening backtick was opened and never closed, this PR correct the issue by adding the closing backtick.

image

@kdelorey
Copy link
Contributor Author

Since I was already making this edit and I had an open PR, I found another case where a missing backtick caused the incorrect formatting behavior to occur when documenting the Mutually Exclusive Network Client section. This time instead of missing the closing backtick, the opening one was missing. I took the liberty and just included a fix into this similar PR.

image

Hope it helps!

Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these small, but impactful fixes :)!

@Byron Byron merged commit 3b34699 into Byron:main Mar 19, 2024
18 checks passed
@kdelorey kdelorey deleted the fix/simple-docs-formatting branch March 20, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants