You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
It appears that incompatible carta-frontend and carta-backend versions can be run together. For example, the v3.0.0 carta-backend can use the v4.0.0 carta-frontend. The most likely scenario for this to happen is with carta-controller if the user only updates carta-controller (which updates carta-frontend) and forgets, or is unaware of the need, to update the carta-backend to the same version. At first, everything will appear to be running fine, but unexpected behaviour will occur.
It would be better if different release/beta versions of the carta-frontend and carta-backend refused to work together.
How it could be done can be discussed. Perhaps with the carta-frontend (and/or carta-backend) can compare their version strings or protobuf versions and alert the user with an error or warning message if they do not match?
To Reproduce
Steps to reproduce the behavior:
Start up a v3.0.0 carta_backend with a v4.0.0 carta-frontend using the --frontend_folder flag.
Open a HDF5 image.
The image will open, but no actual image will be visible.
Open a FITS image.
The carta_backend may crash.
Expected behavior
Different carta-frontend and carta-backend versions should not work together. We should expect an error or warning message that the carta-frontend and carta-backend versions are incompatible.
Screenshots or videos
I can load a HDF5 file, but no image is visible. It is not clear to the user why, but it is because the carta_backend is v3.0.0 and the carta-frontend is v4.0.0-beta.1.
Platform info (please complete the following information):
OS [e.g. macOS Monterey]: macOS Ventura
Browser [e.g. chrome, safari, electron app]: Chrome
Additional context
I will make an identical carta-backend issue as I'm not sure if the carta-backend would also need modification to address this issue.
The text was updated successfully, but these errors were encountered:
See the discussion in the frontend bug -- the frontend should send an additional frontend version field in the RegisterViewer message, and the backend can then use that as well as the interface (ICD) version to decide whether to accept the connection. The backend should perhaps have a set of allowed frontend versions in its App constants, and use that for the comparison.
See the discussion in the frontend bug -- the frontend should send an additional frontend version field in the RegisterViewer message, and the backend can then use that as well as the interface (ICD) version to decide whether to accept the connection. The backend should perhaps have a set of allowed frontend versions in its App constants, and use that for the comparison.
Isn't the idea behind an ICD version to solve exactly this problem? Shouldn't we be bumping the ICD version every time a breaking frontend/backend change is made?
@veggiesaurus At the moment the ICD version is versioning only changes to the protocol itself -- we are not doing anything to the protobuf version if the frontend and backend change their behaviour in sync without any change to the protocol (which is a situation that could happen). We're also only checking the major ICD version. So the question is: do we need to change the way that we're using the ICD version? Is this something that we should put on hold until we can discuss it at the F2F?
Describe the bug
It appears that incompatible carta-frontend and carta-backend versions can be run together. For example, the v3.0.0 carta-backend can use the v4.0.0 carta-frontend. The most likely scenario for this to happen is with carta-controller if the user only updates carta-controller (which updates carta-frontend) and forgets, or is unaware of the need, to update the carta-backend to the same version. At first, everything will appear to be running fine, but unexpected behaviour will occur.
It would be better if different release/beta versions of the carta-frontend and carta-backend refused to work together.
How it could be done can be discussed. Perhaps with the carta-frontend (and/or carta-backend) can compare their version strings or protobuf versions and alert the user with an error or warning message if they do not match?
To Reproduce
Steps to reproduce the behavior:
--frontend_folder
flag.Expected behavior
Different carta-frontend and carta-backend versions should not work together. We should expect an error or warning message that the carta-frontend and carta-backend versions are incompatible.
Screenshots or videos
I can load a HDF5 file, but no image is visible. It is not clear to the user why, but it is because the carta_backend is v3.0.0 and the carta-frontend is v4.0.0-beta.1.
Platform info (please complete the following information):
Additional context
I will make an identical carta-backend issue as I'm not sure if the carta-backend would also need modification to address this issue.
The text was updated successfully, but these errors were encountered: