Mark/1281 Check if the frontend version is compatible #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed
8 tasks
|
I am closing this because of the decision to solve this issue with a different approach to the ICD version. We will still need changes in the backend to support the new approach (to use a single location in the protobuf repo to store the ICD version, and possibly also to use a flag to set the strictness level for the ICD comparison), but this should be done in new PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is implemented or fixed? Mention the linked issue(s), if any.
Fixes Mismatched carta-frontend and carta-backend versions running together #1281.
How does this PR solve the issue? Give a brief summary.
The frontend sends its version info, e.q.,
4.0.0, in theRegisterViewermessage to the backend when connected. The backend then checks if the frontend version is compatible with it, plus the ICD version. If not, the backend sendssuccess == falseand an error message in theRegisterViewerAckto the frontend.Are there any companion PRs (frontend, protobuf)?
Both companions frontend PR and protobuf PR are needed.
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)?
When connected to the frontend, if the frontend version is not compatible with the backend. Then the frontend will receive
success == falseand an error message in theRegisterViewerAckfrom the backend. The frontend could show the error message on the panel to remind the user and disconnect with the backend.Checklist
/ no changelog update needed/ no protobuf update needed